Accumulo
  1. Accumulo
  2. ACCUMULO-2196

ConfigurableMacIT tests should each use their own dirs

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.6.0
    • Component/s: None
    • Labels:

      Description

      GarbageCollectorIT has multiple test methods. MAC is started and stopped for each test method. All of the test methods use the same dir for MAC and clear the dir. So if one methods fails, then output is lost.

      1. ACCUMULO-2196.v1.patch.txt
        2 kB
        Vikram Srivastava
      2. ACCUMULO-2196.v2.patch.txt
        1 kB
        Vikram Srivastava

        Activity

        Hide
        Vikram Srivastava added a comment -

        Attached patch. Verified that all tests in GCIT used their own dirs.

        Show
        Vikram Srivastava added a comment - Attached patch. Verified that all tests in GCIT used their own dirs.
        Hide
        Christopher Tubbs added a comment -

        I'd rather not have a special case just for the GCIT. It'd be better if the per-test directory was done in the base class, so we don't have the same issue in the future, if we create additional methods in other ConfigurableMacITs.

        Show
        Christopher Tubbs added a comment - I'd rather not have a special case just for the GCIT. It'd be better if the per-test directory was done in the base class, so we don't have the same issue in the future, if we create additional methods in other ConfigurableMacITs.
        Hide
        Vikram Srivastava added a comment -

        Christopher Tubbs Using it for all tests definitely makes sense. I wasn't aware of its impact since the jira mentioned only GCIT. I'll repurpose this jira for the base class and submit another patch.

        Show
        Vikram Srivastava added a comment - Christopher Tubbs Using it for all tests definitely makes sense. I wasn't aware of its impact since the jira mentioned only GCIT. I'll repurpose this jira for the base class and submit another patch.
        Hide
        Christopher Tubbs added a comment -

        Vikram Srivastava: Much appreciated. Thank you.

        Show
        Christopher Tubbs added a comment - Vikram Srivastava : Much appreciated. Thank you.
        Hide
        Vikram Srivastava added a comment -

        Attached patch where all tests use their own dir.

        Show
        Vikram Srivastava added a comment - Attached patch where all tests use their own dir.
        Hide
        Keith Turner added a comment -

        I am adding test to VolumeIT and ran into this same issue.

        Show
        Keith Turner added a comment - I am adding test to VolumeIT and ran into this same issue.
        Hide
        ASF subversion and git services added a comment -

        Commit e36ac378d13535b869336c0e6737274d255c72df in branch refs/heads/1.6.0-SNAPSHOT from Vikram Srivastava
        [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=e36ac37 ]

        ACCUMULO-2196 ConfigurableMacIT tests should each use their own dirs

        Signed-off-by: Christopher Tubbs <ctubbsii@apache.org>

        Show
        ASF subversion and git services added a comment - Commit e36ac378d13535b869336c0e6737274d255c72df in branch refs/heads/1.6.0-SNAPSHOT from Vikram Srivastava [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=e36ac37 ] ACCUMULO-2196 ConfigurableMacIT tests should each use their own dirs Signed-off-by: Christopher Tubbs <ctubbsii@apache.org>
        Hide
        Christopher Tubbs added a comment -

        Tested and applied.

        Show
        Christopher Tubbs added a comment - Tested and applied.
        Hide
        ASF subversion and git services added a comment -

        Commit e36ac378d13535b869336c0e6737274d255c72df in branch refs/heads/master from Vikram Srivastava
        [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=e36ac37 ]

        ACCUMULO-2196 ConfigurableMacIT tests should each use their own dirs

        Signed-off-by: Christopher Tubbs <ctubbsii@apache.org>

        Show
        ASF subversion and git services added a comment - Commit e36ac378d13535b869336c0e6737274d255c72df in branch refs/heads/master from Vikram Srivastava [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=e36ac37 ] ACCUMULO-2196 ConfigurableMacIT tests should each use their own dirs Signed-off-by: Christopher Tubbs <ctubbsii@apache.org>

          People

          • Assignee:
            Vikram Srivastava
            Reporter:
            Keith Turner
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development