• Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.7.0
    • Component/s: tserver
    • Labels:


      Tablet has some very delicate state stored in several variables. Translate this into some sort of sane state machine, with appropriate, clean log messages when the state transitions. I'm specifically thinking of closing, closed, closeComplete and closeCompleting. That's 16 possible states, but I'm thinking that only a few make any sense. May want to look at the ...InProgress and ..WaitingToStart booleans, too. Some of the embedded classes could be moved out to their own files, just to reduce the size of the class. There are 17 uses of the keyword class in this one file. The constructor nesting is pretty crazy. The constructor is doing too much. It should not be doing recovery, for example. It should not be passing "this" to anything. Small things, like extent, fs, conf should be final. Anything that would facilitate unit testing would be welcome.

      1. ACCUMULO-2041-v2.patch
        466 kB
        Eric Newton
      2. ACCUMULO-2041-v1.patch
        439 kB
        Eric Newton

        Issue Links


          Eric Newton made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Josh Elser made changes -
          Link This issue relates to ACCUMULO-2872 [ ACCUMULO-2872 ]
          Eric Newton made changes -
          Attachment ACCUMULO-2041-v2.patch [ 12641117 ]
          Eric Newton made changes -
          Attachment ACCUMULO-2041-v1.patch [ 12641107 ]
          Eric Newton made changes -
          Field Original Value New Value
          Remote Link This issue links to "ACCUMULO-2041-v0.patch (Web Link)" [ 14899 ]
          Eric Newton created issue -


            • Assignee:
              Eric Newton
              Eric Newton
            • Votes:
              0 Vote for this issue
              5 Start watching this issue


              • Created: