Accumulo
  1. Accumulo
  2. ACCUMULO-1961

Fix trivial compiler/javadoc warnings

    Details

    • Type: Task Task
    • Status: Resolved
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.4.4, 1.5.0
    • Fix Version/s: 1.4.5, 1.5.1, 1.6.0
    • Component/s: None
    • Labels:
      None

      Description

      Clean up trivial 1.6 compiler/javadoc warnings across all versions currently in development.

        Activity

        Hide
        ASF subversion and git services added a comment -

        Commit a3a889554940d249504a2b03c0e6dda2a25ef5cd in branch refs/heads/1.4.5-SNAPSHOT from Christopher Tubbs
        [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=a3a8895 ]

        ACCUMULO-1961 Fix warnings

        Show
        ASF subversion and git services added a comment - Commit a3a889554940d249504a2b03c0e6dda2a25ef5cd in branch refs/heads/1.4.5-SNAPSHOT from Christopher Tubbs [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=a3a8895 ] ACCUMULO-1961 Fix warnings
        Hide
        ASF subversion and git services added a comment -

        Commit a3a889554940d249504a2b03c0e6dda2a25ef5cd in branch refs/heads/1.5.1-SNAPSHOT from Christopher Tubbs
        [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=a3a8895 ]

        ACCUMULO-1961 Fix warnings

        Show
        ASF subversion and git services added a comment - Commit a3a889554940d249504a2b03c0e6dda2a25ef5cd in branch refs/heads/1.5.1-SNAPSHOT from Christopher Tubbs [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=a3a8895 ] ACCUMULO-1961 Fix warnings
        Hide
        ASF subversion and git services added a comment -

        Commit a3a889554940d249504a2b03c0e6dda2a25ef5cd in branch refs/heads/1.6.0-SNAPSHOT from Christopher Tubbs
        [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=a3a8895 ]

        ACCUMULO-1961 Fix warnings

        Show
        ASF subversion and git services added a comment - Commit a3a889554940d249504a2b03c0e6dda2a25ef5cd in branch refs/heads/1.6.0-SNAPSHOT from Christopher Tubbs [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=a3a8895 ] ACCUMULO-1961 Fix warnings
        Hide
        ASF subversion and git services added a comment -

        Commit a3a889554940d249504a2b03c0e6dda2a25ef5cd in branch refs/heads/master from Christopher Tubbs
        [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=a3a8895 ]

        ACCUMULO-1961 Fix warnings

        Show
        ASF subversion and git services added a comment - Commit a3a889554940d249504a2b03c0e6dda2a25ef5cd in branch refs/heads/master from Christopher Tubbs [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=a3a8895 ] ACCUMULO-1961 Fix warnings
        Hide
        ASF subversion and git services added a comment -

        Commit 64d66e1dca281e7022ca5329f31b553ac8ebc172 in branch refs/heads/1.6.0-SNAPSHOT from Eric Newton
        [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=64d66e1 ]

        ACCUMULO-1961 eliminate warnings

        Show
        ASF subversion and git services added a comment - Commit 64d66e1dca281e7022ca5329f31b553ac8ebc172 in branch refs/heads/1.6.0-SNAPSHOT from Eric Newton [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=64d66e1 ] ACCUMULO-1961 eliminate warnings
        Hide
        ASF subversion and git services added a comment -

        Commit 64d66e1dca281e7022ca5329f31b553ac8ebc172 in branch refs/heads/master from Eric Newton
        [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=64d66e1 ]

        ACCUMULO-1961 eliminate warnings

        Show
        ASF subversion and git services added a comment - Commit 64d66e1dca281e7022ca5329f31b553ac8ebc172 in branch refs/heads/master from Eric Newton [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=64d66e1 ] ACCUMULO-1961 eliminate warnings
        Hide
        ASF subversion and git services added a comment -

        Commit f1ae5a860bf7a32efc744adb52f54d1a394fd6b0 in branch refs/heads/1.5.1-SNAPSHOT from Eric Newton
        [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=f1ae5a8 ]

        ACCUMULO-1961 removing trivial warnings

        Show
        ASF subversion and git services added a comment - Commit f1ae5a860bf7a32efc744adb52f54d1a394fd6b0 in branch refs/heads/1.5.1-SNAPSHOT from Eric Newton [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=f1ae5a8 ] ACCUMULO-1961 removing trivial warnings
        Hide
        ASF subversion and git services added a comment -

        Commit f1ae5a860bf7a32efc744adb52f54d1a394fd6b0 in branch refs/heads/1.6.0-SNAPSHOT from Eric Newton
        [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=f1ae5a8 ]

        ACCUMULO-1961 removing trivial warnings

        Show
        ASF subversion and git services added a comment - Commit f1ae5a860bf7a32efc744adb52f54d1a394fd6b0 in branch refs/heads/1.6.0-SNAPSHOT from Eric Newton [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=f1ae5a8 ] ACCUMULO-1961 removing trivial warnings
        Hide
        ASF subversion and git services added a comment -

        Commit f1ae5a860bf7a32efc744adb52f54d1a394fd6b0 in branch refs/heads/master from Eric Newton
        [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=f1ae5a8 ]

        ACCUMULO-1961 removing trivial warnings

        Show
        ASF subversion and git services added a comment - Commit f1ae5a860bf7a32efc744adb52f54d1a394fd6b0 in branch refs/heads/master from Eric Newton [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=f1ae5a8 ] ACCUMULO-1961 removing trivial warnings
        Hide
        ASF subversion and git services added a comment -

        Commit 7820120fb2ce4c18317ab77b6439197084ceac8f in branch refs/heads/1.6.0-SNAPSHOT from Christopher Tubbs
        [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=7820120 ]

        ACCUMULO-1961 Fix/remove some more trivial warnings

        Show
        ASF subversion and git services added a comment - Commit 7820120fb2ce4c18317ab77b6439197084ceac8f in branch refs/heads/1.6.0-SNAPSHOT from Christopher Tubbs [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=7820120 ] ACCUMULO-1961 Fix/remove some more trivial warnings
        Hide
        ASF subversion and git services added a comment -

        Commit b68ae97b92fc5e429fc42913708159eca993e2a6 in branch refs/heads/1.6.0-SNAPSHOT from Eric Newton
        [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=b68ae97 ]

        ACCUMULO-1961 remove unused imports and variables

        Show
        ASF subversion and git services added a comment - Commit b68ae97b92fc5e429fc42913708159eca993e2a6 in branch refs/heads/1.6.0-SNAPSHOT from Eric Newton [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=b68ae97 ] ACCUMULO-1961 remove unused imports and variables
        Hide
        ASF subversion and git services added a comment -

        Commit b68ae97b92fc5e429fc42913708159eca993e2a6 in branch refs/heads/master from Eric Newton
        [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=b68ae97 ]

        ACCUMULO-1961 remove unused imports and variables

        Show
        ASF subversion and git services added a comment - Commit b68ae97b92fc5e429fc42913708159eca993e2a6 in branch refs/heads/master from Eric Newton [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=b68ae97 ] ACCUMULO-1961 remove unused imports and variables
        Hide
        ASF subversion and git services added a comment -

        Commit eea885a32c1b586f1e87991fbeb0b7f8e07b9b9a in accumulo's branch refs/heads/1.5.1-SNAPSHOT from Eric Newton
        [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=eea885a ]

        ACCUMULO-1961 fixing warnings

        Show
        ASF subversion and git services added a comment - Commit eea885a32c1b586f1e87991fbeb0b7f8e07b9b9a in accumulo's branch refs/heads/1.5.1-SNAPSHOT from Eric Newton [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=eea885a ] ACCUMULO-1961 fixing warnings
        Hide
        ASF subversion and git services added a comment -

        Commit eea885a32c1b586f1e87991fbeb0b7f8e07b9b9a in accumulo's branch refs/heads/1.6.0-SNAPSHOT from Eric Newton
        [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=eea885a ]

        ACCUMULO-1961 fixing warnings

        Show
        ASF subversion and git services added a comment - Commit eea885a32c1b586f1e87991fbeb0b7f8e07b9b9a in accumulo's branch refs/heads/1.6.0-SNAPSHOT from Eric Newton [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=eea885a ] ACCUMULO-1961 fixing warnings
        Hide
        ASF subversion and git services added a comment -

        Commit 732f037ea029f32715ffeff82b6cd2e880e2fdf6 in accumulo's branch refs/heads/1.6.0-SNAPSHOT from Eric Newton
        [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=732f037 ]

        ACCUMULO-1961 fixing warnings

        Show
        ASF subversion and git services added a comment - Commit 732f037ea029f32715ffeff82b6cd2e880e2fdf6 in accumulo's branch refs/heads/1.6.0-SNAPSHOT from Eric Newton [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=732f037 ] ACCUMULO-1961 fixing warnings
        Hide
        ASF subversion and git services added a comment -

        Commit eea885a32c1b586f1e87991fbeb0b7f8e07b9b9a in accumulo's branch refs/heads/master from Eric Newton
        [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=eea885a ]

        ACCUMULO-1961 fixing warnings

        Show
        ASF subversion and git services added a comment - Commit eea885a32c1b586f1e87991fbeb0b7f8e07b9b9a in accumulo's branch refs/heads/master from Eric Newton [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=eea885a ] ACCUMULO-1961 fixing warnings
        Hide
        ASF subversion and git services added a comment -

        Commit 732f037ea029f32715ffeff82b6cd2e880e2fdf6 in accumulo's branch refs/heads/master from Eric Newton
        [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=732f037 ]

        ACCUMULO-1961 fixing warnings

        Show
        ASF subversion and git services added a comment - Commit 732f037ea029f32715ffeff82b6cd2e880e2fdf6 in accumulo's branch refs/heads/master from Eric Newton [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=732f037 ] ACCUMULO-1961 fixing warnings
        Hide
        ASF subversion and git services added a comment -

        Commit 4abb3f1afd7c0f44cb71671148629cfcbbf5746f in accumulo's branch refs/heads/1.6.0-SNAPSHOT from Christopher Tubbs
        [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=4abb3f1 ]

        ACCUMULO-1961 Fix more recently introduced javadoc problems.

        Show
        ASF subversion and git services added a comment - Commit 4abb3f1afd7c0f44cb71671148629cfcbbf5746f in accumulo's branch refs/heads/1.6.0-SNAPSHOT from Christopher Tubbs [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=4abb3f1 ] ACCUMULO-1961 Fix more recently introduced javadoc problems.
        Hide
        ASF subversion and git services added a comment -

        Commit 4abb3f1afd7c0f44cb71671148629cfcbbf5746f in accumulo's branch refs/heads/master from Christopher Tubbs
        [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=4abb3f1 ]

        ACCUMULO-1961 Fix more recently introduced javadoc problems.

        Show
        ASF subversion and git services added a comment - Commit 4abb3f1afd7c0f44cb71671148629cfcbbf5746f in accumulo's branch refs/heads/master from Christopher Tubbs [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=4abb3f1 ] ACCUMULO-1961 Fix more recently introduced javadoc problems.
        Hide
        Bill Havanki added a comment -

        Christopher Tubbs, I believe my merge to master for ACCUMULO-2378 dropped your latest commit 4abb3f1. When I did the initial merge, expecting no changes, I saw what I later discovered was 4abb3f1. At the time, I instead did a merge with -sours, which I think has caused the commit to be left out of master.

        I'll be happy to cherry-pick the commit up to master if it should be present there. Just let me know.

        Show
        Bill Havanki added a comment - Christopher Tubbs , I believe my merge to master for ACCUMULO-2378 dropped your latest commit 4abb3f1. When I did the initial merge, expecting no changes, I saw what I later discovered was 4abb3f1. At the time, I instead did a merge with -sours, which I think has caused the commit to be left out of master. I'll be happy to cherry-pick the commit up to master if it should be present there. Just let me know.
        Hide
        Christopher Tubbs added a comment -

        It looks like you are right. Be careful about -sours. You should probably only use that with specific commits, not the HEAD of the branch, which could reference multiple commits.

        Don't worry about fixing it. I'll redo. There's some other javadoc errors/warnings and other trivial warnings in master that need to be fixed anyway.

        Show
        Christopher Tubbs added a comment - It looks like you are right. Be careful about -sours. You should probably only use that with specific commits, not the HEAD of the branch, which could reference multiple commits. Don't worry about fixing it. I'll redo. There's some other javadoc errors/warnings and other trivial warnings in master that need to be fixed anyway.
        Hide
        Mike Drob added a comment -

        Christopher Tubbs - If Bill Havanki had committed his changes (e.g. into 1.5.1-SNAPSHOT) after you committed yours, but you did not merge your changes up to the next branch (1.6.0) then he has no way to just merge his work and not yours. He'd have to do a cherry pick of his own work up, which I don't think is a sustainable workflow. I'm not sure what exactly happened, so it's hard to comment, but the general answer is to just always merge your own changes up!

        Show
        Mike Drob added a comment - Christopher Tubbs - If Bill Havanki had committed his changes (e.g. into 1.5.1-SNAPSHOT) after you committed yours, but you did not merge your changes up to the next branch (1.6.0) then he has no way to just merge his work and not yours. He'd have to do a cherry pick of his own work up, which I don't think is a sustainable workflow. I'm not sure what exactly happened, so it's hard to comment, but the general answer is to just always merge your own changes up!
        Hide
        ASF subversion and git services added a comment -

        Commit dcc19ccbada8c2f0a206ec797455294015e8ca6d in accumulo's branch refs/heads/master from Christopher Tubbs
        [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=dcc19cc ]

        ACCUMULO-1961 Re-apply inadvertently dropped 4abb3f1 to master branch

        Fixes trivial warnings and broken javadocs which have been recently
        introduced. Specifically, removes references to private and
        package-private (default) classes in public javadoc comments (internal
        details aren't relevant to the API and subject to change). Another
        common warning was unused imports and javadoc param tags that refer to
        non-existent parameters.

        Commits against the following JIRA issues introduced these:
        ACCUMULO-1948, ACCUMULO-1974, ACCUMULO-2021, ACCUMULO-2136,
        ACCUMULO-2322, ACCUMULO-2334, ACCUMULO-2350

        Show
        ASF subversion and git services added a comment - Commit dcc19ccbada8c2f0a206ec797455294015e8ca6d in accumulo's branch refs/heads/master from Christopher Tubbs [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=dcc19cc ] ACCUMULO-1961 Re-apply inadvertently dropped 4abb3f1 to master branch Fixes trivial warnings and broken javadocs which have been recently introduced. Specifically, removes references to private and package-private (default) classes in public javadoc comments (internal details aren't relevant to the API and subject to change). Another common warning was unused imports and javadoc param tags that refer to non-existent parameters. Commits against the following JIRA issues introduced these: ACCUMULO-1948 , ACCUMULO-1974 , ACCUMULO-2021 , ACCUMULO-2136 , ACCUMULO-2322 , ACCUMULO-2334 , ACCUMULO-2350

          People

          • Assignee:
            Christopher Tubbs
            Reporter:
            Christopher Tubbs
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development