Accumulo
  1. Accumulo
  2. ACCUMULO-1903

Monitor creates a new ZK object to fetch gc status and doesn't wait for it to connect.

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.4.4, 1.5.0
    • Fix Version/s: 1.4.5, 1.5.1, 1.6.0
    • Component/s: monitor
    • Labels:

      Description

      May affect older versions, didn't check them for the same code, but it does exist in 1.5.1-SNAPSHOT and 1.6.0-SNAPSHOT currently.

      Seeing a warning in the monitor "Unable to contact the garbage collector at null", stemming from a KeeperException KeeperErrorCode ConnectionLoss in fetchGcStatus().

      Initially I thought this was just a connection error, but I took a look at the code and a quick google search led me to http://zookeeper-user.578899.n2.nabble.com/zookeeper-connection-loss-exception-occurs-on-new-created-ZooKeeper-instance-too-much-why-td6766831.html

      In the getchGcStatus() we create a new ZooKeeper object with every call and then immediately try to use it (!!) without waiting for it to finish establishing a connection. Because of these, I think we should A. ensure it's connected before attempting to use and B. try to reuse the same ZK object instead of creating a new one for each call.

        Activity

        Hide
        Ivan Bella added a comment -

        At least use the Watcher parameter....

        Show
        Ivan Bella added a comment - At least use the Watcher parameter....
        Show
        Ivan Bella added a comment - http://zookeeper.apache.org/doc/r3.3.3/api/org/apache/zookeeper/ZooKeeper.html#ZooKeeper(java.lang.String , int, org.apache.zookeeper.Watcher)
        Hide
        ASF subversion and git services added a comment -

        Commit 32b6b65766a695b8da76bdee36df13baace6f904 in branch refs/heads/1.4.5-SNAPSHOT from Eric Newton
        [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=32b6b65 ]

        ACCUMULO-1903 prefer the cached, reusable ZooReaderWriter over raw Zookeeper API

        Show
        ASF subversion and git services added a comment - Commit 32b6b65766a695b8da76bdee36df13baace6f904 in branch refs/heads/1.4.5-SNAPSHOT from Eric Newton [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=32b6b65 ] ACCUMULO-1903 prefer the cached, reusable ZooReaderWriter over raw Zookeeper API
        Hide
        ASF subversion and git services added a comment -

        Commit 32b6b65766a695b8da76bdee36df13baace6f904 in branch refs/heads/1.5.1-SNAPSHOT from Eric Newton
        [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=32b6b65 ]

        ACCUMULO-1903 prefer the cached, reusable ZooReaderWriter over raw Zookeeper API

        Show
        ASF subversion and git services added a comment - Commit 32b6b65766a695b8da76bdee36df13baace6f904 in branch refs/heads/1.5.1-SNAPSHOT from Eric Newton [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=32b6b65 ] ACCUMULO-1903 prefer the cached, reusable ZooReaderWriter over raw Zookeeper API
        Hide
        ASF subversion and git services added a comment -

        Commit bf8c90a02b7bef0b53790bccfe3f3bd30434243f in branch refs/heads/1.5.1-SNAPSHOT from Eric Newton
        [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=bf8c90a ]

        ACCUMULO-1903 prefer the cached, reusable ZooReaderWriter over raw Zookeeper API

        Show
        ASF subversion and git services added a comment - Commit bf8c90a02b7bef0b53790bccfe3f3bd30434243f in branch refs/heads/1.5.1-SNAPSHOT from Eric Newton [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=bf8c90a ] ACCUMULO-1903 prefer the cached, reusable ZooReaderWriter over raw Zookeeper API
        Hide
        ASF subversion and git services added a comment -

        Commit 32b6b65766a695b8da76bdee36df13baace6f904 in branch refs/heads/master from Eric Newton
        [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=32b6b65 ]

        ACCUMULO-1903 prefer the cached, reusable ZooReaderWriter over raw Zookeeper API

        Show
        ASF subversion and git services added a comment - Commit 32b6b65766a695b8da76bdee36df13baace6f904 in branch refs/heads/master from Eric Newton [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=32b6b65 ] ACCUMULO-1903 prefer the cached, reusable ZooReaderWriter over raw Zookeeper API
        Hide
        ASF subversion and git services added a comment -

        Commit bf8c90a02b7bef0b53790bccfe3f3bd30434243f in branch refs/heads/master from Eric Newton
        [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=bf8c90a ]

        ACCUMULO-1903 prefer the cached, reusable ZooReaderWriter over raw Zookeeper API

        Show
        ASF subversion and git services added a comment - Commit bf8c90a02b7bef0b53790bccfe3f3bd30434243f in branch refs/heads/master from Eric Newton [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=bf8c90a ] ACCUMULO-1903 prefer the cached, reusable ZooReaderWriter over raw Zookeeper API
        Hide
        ASF subversion and git services added a comment -

        Commit e4fb07c2072dd6a57b5bdc0d3c14c5722c9806ef in branch refs/heads/master from Eric Newton
        [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=e4fb07c ]

        ACCUMULO-1903 prefer the cached, reusable ZooReaderWriter over raw Zookeeper API

        Show
        ASF subversion and git services added a comment - Commit e4fb07c2072dd6a57b5bdc0d3c14c5722c9806ef in branch refs/heads/master from Eric Newton [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=e4fb07c ] ACCUMULO-1903 prefer the cached, reusable ZooReaderWriter over raw Zookeeper API
        Hide
        ASF subversion and git services added a comment -

        Commit 32b6b65766a695b8da76bdee36df13baace6f904 in branch refs/heads/1.6.0-SNAPSHOT from Eric Newton
        [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=32b6b65 ]

        ACCUMULO-1903 prefer the cached, reusable ZooReaderWriter over raw Zookeeper API

        Show
        ASF subversion and git services added a comment - Commit 32b6b65766a695b8da76bdee36df13baace6f904 in branch refs/heads/1.6.0-SNAPSHOT from Eric Newton [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=32b6b65 ] ACCUMULO-1903 prefer the cached, reusable ZooReaderWriter over raw Zookeeper API
        Hide
        ASF subversion and git services added a comment -

        Commit bf8c90a02b7bef0b53790bccfe3f3bd30434243f in branch refs/heads/1.6.0-SNAPSHOT from Eric Newton
        [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=bf8c90a ]

        ACCUMULO-1903 prefer the cached, reusable ZooReaderWriter over raw Zookeeper API

        Show
        ASF subversion and git services added a comment - Commit bf8c90a02b7bef0b53790bccfe3f3bd30434243f in branch refs/heads/1.6.0-SNAPSHOT from Eric Newton [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=bf8c90a ] ACCUMULO-1903 prefer the cached, reusable ZooReaderWriter over raw Zookeeper API
        Hide
        ASF subversion and git services added a comment -

        Commit 55016d7762a8f40386c8c567b666fa5e04dc57ab in branch refs/heads/1.6.0-SNAPSHOT from Eric Newton
        [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=55016d7 ]

        ACCUMULO-1903 prefer the cached, reusable ZooReaderWriter over raw Zookeeper API

        Show
        ASF subversion and git services added a comment - Commit 55016d7762a8f40386c8c567b666fa5e04dc57ab in branch refs/heads/1.6.0-SNAPSHOT from Eric Newton [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=55016d7 ] ACCUMULO-1903 prefer the cached, reusable ZooReaderWriter over raw Zookeeper API
        Hide
        ASF subversion and git services added a comment -

        Commit 55016d7762a8f40386c8c567b666fa5e04dc57ab in branch refs/heads/master from Eric Newton
        [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=55016d7 ]

        ACCUMULO-1903 prefer the cached, reusable ZooReaderWriter over raw Zookeeper API

        Show
        ASF subversion and git services added a comment - Commit 55016d7762a8f40386c8c567b666fa5e04dc57ab in branch refs/heads/master from Eric Newton [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=55016d7 ] ACCUMULO-1903 prefer the cached, reusable ZooReaderWriter over raw Zookeeper API

          People

          • Assignee:
            Eric Newton
            Reporter:
            John Vines
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development