[ACCUMULO-1889] ZooKeeperInstance close method should mark instance closed.

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.4.5, 1.5.1
• Fix Version/s: 1.4.5, 1.5.1, 1.6.0
• Assignee: Sean Busbey
• Reporter: Sean Busbey
• Created: 13/Nov/13 16:53
• Updated: 28/Apr/14 19:06
• Resolved: 19/Nov/13 17:40

Description

(1.4.5 and 1.5.1 impact presumes ACCUMULO-1858 gets applied)

The current close() implementation on ZooKeeperInstance only marks a given instance as closed if the outstanding client count is 0.

  public synchronized void close() throws AccumuloException {
    if (!closed && clientInstances.decrementAndGet() == 0) {
      try {
        zooCache.close();
        ThriftUtil.close();
      } catch (InterruptedException e) {
        clientInstances.incrementAndGet();
        throw new AccumuloException("Issues closing ZooKeeper.");
      }
      closed = true;
    }
  }

This is incorrect for two reason:

1) It allows continued operations on a given ZKI after it has had close() called on it

2) It allows a given ZKI to decrement the number of open clients more than once

Issue Links

• depends upon: ACCUMULO-1858 Backport fix for Accumulo-1379 PermGen Leak to 1.4 and 1.5
• links to: review board