Accumulo
  1. Accumulo
  2. ACCUMULO-1789

Increase test timeouts for Accumulo 1.5.x

    Details

    • Type: Test Test
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.5.0
    • Fix Version/s: 1.5.1
    • Component/s: test
    • Labels:

      Description

      In our test environment we've found that increasing some timeouts for Accumulo 1.5.x tests lets them complete more reliably. They include: CreateAndUseTest, BloomFilterTest, SimpleBalancerFairness, DeleteRowsSplitTest, MergeTest.

        Issue Links

          Activity

          Hide
          Eric Newton added a comment -

          What did you change the timeouts to?

          Show
          Eric Newton added a comment - What did you change the timeouts to?
          Hide
          Bill Havanki added a comment -

          Review of proposed patch available: https://reviews.apache.org/r/14844/.

          Show
          Bill Havanki added a comment - Review of proposed patch available: https://reviews.apache.org/r/14844/ .
          Hide
          Bill Havanki added a comment -

          I had generally increased some timeouts by a factor of two to three. The
          maxRuntime value of 120 in JavaTest was one I had to increase to 360 for
          many tests. There were also onesy-twosy changes I had to make in
          SimpleBalancerFairness, DeleteRowsSplitTest, MergeTest, and
          MetadataMaxFiles.

          However, based on a comment by Steve Loughran, I decided to add the ability
          to scale the timeouts at run time instead of just poke in what worked for
          me. This way, the original timeouts stay there, but anyone can scale them
          up for their particular environment.


          // - - -
          // Bill Havanki
          // Solutions Architect, Cloudera
          // - - -

          Show
          Bill Havanki added a comment - I had generally increased some timeouts by a factor of two to three. The maxRuntime value of 120 in JavaTest was one I had to increase to 360 for many tests. There were also onesy-twosy changes I had to make in SimpleBalancerFairness, DeleteRowsSplitTest, MergeTest, and MetadataMaxFiles. However, based on a comment by Steve Loughran, I decided to add the ability to scale the timeouts at run time instead of just poke in what worked for me. This way, the original timeouts stay there, but anyone can scale them up for their particular environment. – // - - - // Bill Havanki // Solutions Architect, Cloudera // - - -
          Hide
          ASF subversion and git services added a comment -

          Commit 0fe0a5a5b72da02bd2e07bc8c87e808c0c9653dc in branch refs/heads/1.5.1-SNAPSHOT from Bill Havanki
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=0fe0a5a ]

          ACCUMULO-1789 Add timeout scaling factor to tests

          Slower hardware or VMs may have trouble completing tests within the timeouts
          specified. This change adds a -f option to run.py to add a scaling factor
          to the maxRuntime for tests, the timeout for Accumulo to shut down, and to
          a specific timeout in SimpleBalancerFairness.

          Signed-off-by: Eric Newton <eric.newton@gmail.com>

          Show
          ASF subversion and git services added a comment - Commit 0fe0a5a5b72da02bd2e07bc8c87e808c0c9653dc in branch refs/heads/1.5.1-SNAPSHOT from Bill Havanki [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=0fe0a5a ] ACCUMULO-1789 Add timeout scaling factor to tests Slower hardware or VMs may have trouble completing tests within the timeouts specified. This change adds a -f option to run.py to add a scaling factor to the maxRuntime for tests, the timeout for Accumulo to shut down, and to a specific timeout in SimpleBalancerFairness. Signed-off-by: Eric Newton <eric.newton@gmail.com>
          Hide
          ASF subversion and git services added a comment -

          Commit 0fe0a5a5b72da02bd2e07bc8c87e808c0c9653dc in branch refs/heads/master from Bill Havanki
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=0fe0a5a ]

          ACCUMULO-1789 Add timeout scaling factor to tests

          Slower hardware or VMs may have trouble completing tests within the timeouts
          specified. This change adds a -f option to run.py to add a scaling factor
          to the maxRuntime for tests, the timeout for Accumulo to shut down, and to
          a specific timeout in SimpleBalancerFairness.

          Signed-off-by: Eric Newton <eric.newton@gmail.com>

          Show
          ASF subversion and git services added a comment - Commit 0fe0a5a5b72da02bd2e07bc8c87e808c0c9653dc in branch refs/heads/master from Bill Havanki [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=0fe0a5a ] ACCUMULO-1789 Add timeout scaling factor to tests Slower hardware or VMs may have trouble completing tests within the timeouts specified. This change adds a -f option to run.py to add a scaling factor to the maxRuntime for tests, the timeout for Accumulo to shut down, and to a specific timeout in SimpleBalancerFairness. Signed-off-by: Eric Newton <eric.newton@gmail.com>
          Hide
          Sean Busbey added a comment -

          I think this can be closed?

          Show
          Sean Busbey added a comment - I think this can be closed?
          Hide
          John Vines added a comment -

          How do I apply the scaling factor to the tests in 1.6, since they're not python based anymore?

          Show
          John Vines added a comment - How do I apply the scaling factor to the tests in 1.6, since they're not python based anymore?
          Hide
          Christopher Tubbs added a comment -

          I'm not sure we can apply them to 1.6, unless we can manipulate the JUnit tooling.

          Show
          Christopher Tubbs added a comment - I'm not sure we can apply them to 1.6, unless we can manipulate the JUnit tooling.
          Hide
          Bill Havanki added a comment -

          Right, it looks like some of the Python infrastructure remains, but the
          rest went into Java, so some changes would have to be migrated there.

          On Mon, Oct 28, 2013 at 2:48 PM, Christopher Tubbs (JIRA)


          // - - -
          // Bill Havanki
          // Solutions Architect, Cloudera
          // - - -

          Show
          Bill Havanki added a comment - Right, it looks like some of the Python infrastructure remains, but the rest went into Java, so some changes would have to be migrated there. On Mon, Oct 28, 2013 at 2:48 PM, Christopher Tubbs (JIRA) – // - - - // Bill Havanki // Solutions Architect, Cloudera // - - -
          Hide
          Eric Newton added a comment -

          Bill Havanki do a git pull, I removed test/system/auto from 1.6.0-SNAPSHOT last week.

          John Vines if you find that your tests are passing regularly with longer timeouts, please increase the relative timeouts.

          Show
          Eric Newton added a comment - Bill Havanki do a git pull, I removed test/system/auto from 1.6.0-SNAPSHOT last week. John Vines if you find that your tests are passing regularly with longer timeouts, please increase the relative timeouts.
          Hide
          Bill Havanki added a comment -

          Ah, so you did. Thanks Eric!

          Show
          Bill Havanki added a comment - Ah, so you did. Thanks Eric!
          Hide
          ASF subversion and git services added a comment -

          Commit 41efe1a7e07d3abae1d82bc6d8340e78210cadc0 in branch refs/heads/1.4.5-SNAPSHOT from Bill Havanki
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=41efe1a ]

          ACCUMULO-1829 Add timeout scaling factor to tests (1.4.x)

          Slower hardware or VMs may have trouble completing tests within the timeouts
          specified. This change adds a -f option to run.py to add a scaling factor
          to the maxRuntime for tests, the timeout for Accumulo to shut down, and to
          specific timeouts in SimpleBalancerFairness and ZooCacheTest.

          Compare to a similar change for ACCUMULO-1789.

          Signed-off-by: Eric Newton <eric.newton@gmail.com>

          Show
          ASF subversion and git services added a comment - Commit 41efe1a7e07d3abae1d82bc6d8340e78210cadc0 in branch refs/heads/1.4.5-SNAPSHOT from Bill Havanki [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=41efe1a ] ACCUMULO-1829 Add timeout scaling factor to tests (1.4.x) Slower hardware or VMs may have trouble completing tests within the timeouts specified. This change adds a -f option to run.py to add a scaling factor to the maxRuntime for tests, the timeout for Accumulo to shut down, and to specific timeouts in SimpleBalancerFairness and ZooCacheTest. Compare to a similar change for ACCUMULO-1789 . Signed-off-by: Eric Newton <eric.newton@gmail.com>
          Hide
          ASF subversion and git services added a comment -

          Commit 41efe1a7e07d3abae1d82bc6d8340e78210cadc0 in branch refs/heads/1.5.1-SNAPSHOT from Bill Havanki
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=41efe1a ]

          ACCUMULO-1829 Add timeout scaling factor to tests (1.4.x)

          Slower hardware or VMs may have trouble completing tests within the timeouts
          specified. This change adds a -f option to run.py to add a scaling factor
          to the maxRuntime for tests, the timeout for Accumulo to shut down, and to
          specific timeouts in SimpleBalancerFairness and ZooCacheTest.

          Compare to a similar change for ACCUMULO-1789.

          Signed-off-by: Eric Newton <eric.newton@gmail.com>

          Show
          ASF subversion and git services added a comment - Commit 41efe1a7e07d3abae1d82bc6d8340e78210cadc0 in branch refs/heads/1.5.1-SNAPSHOT from Bill Havanki [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=41efe1a ] ACCUMULO-1829 Add timeout scaling factor to tests (1.4.x) Slower hardware or VMs may have trouble completing tests within the timeouts specified. This change adds a -f option to run.py to add a scaling factor to the maxRuntime for tests, the timeout for Accumulo to shut down, and to specific timeouts in SimpleBalancerFairness and ZooCacheTest. Compare to a similar change for ACCUMULO-1789 . Signed-off-by: Eric Newton <eric.newton@gmail.com>
          Hide
          ASF subversion and git services added a comment -

          Commit 41efe1a7e07d3abae1d82bc6d8340e78210cadc0 in branch refs/heads/1.6.0-SNAPSHOT from Bill Havanki
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=41efe1a ]

          ACCUMULO-1829 Add timeout scaling factor to tests (1.4.x)

          Slower hardware or VMs may have trouble completing tests within the timeouts
          specified. This change adds a -f option to run.py to add a scaling factor
          to the maxRuntime for tests, the timeout for Accumulo to shut down, and to
          specific timeouts in SimpleBalancerFairness and ZooCacheTest.

          Compare to a similar change for ACCUMULO-1789.

          Signed-off-by: Eric Newton <eric.newton@gmail.com>

          Show
          ASF subversion and git services added a comment - Commit 41efe1a7e07d3abae1d82bc6d8340e78210cadc0 in branch refs/heads/1.6.0-SNAPSHOT from Bill Havanki [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=41efe1a ] ACCUMULO-1829 Add timeout scaling factor to tests (1.4.x) Slower hardware or VMs may have trouble completing tests within the timeouts specified. This change adds a -f option to run.py to add a scaling factor to the maxRuntime for tests, the timeout for Accumulo to shut down, and to specific timeouts in SimpleBalancerFairness and ZooCacheTest. Compare to a similar change for ACCUMULO-1789 . Signed-off-by: Eric Newton <eric.newton@gmail.com>
          Hide
          ASF subversion and git services added a comment -

          Commit 41efe1a7e07d3abae1d82bc6d8340e78210cadc0 in branch refs/heads/master from Bill Havanki
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=41efe1a ]

          ACCUMULO-1829 Add timeout scaling factor to tests (1.4.x)

          Slower hardware or VMs may have trouble completing tests within the timeouts
          specified. This change adds a -f option to run.py to add a scaling factor
          to the maxRuntime for tests, the timeout for Accumulo to shut down, and to
          specific timeouts in SimpleBalancerFairness and ZooCacheTest.

          Compare to a similar change for ACCUMULO-1789.

          Signed-off-by: Eric Newton <eric.newton@gmail.com>

          Show
          ASF subversion and git services added a comment - Commit 41efe1a7e07d3abae1d82bc6d8340e78210cadc0 in branch refs/heads/master from Bill Havanki [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=41efe1a ] ACCUMULO-1829 Add timeout scaling factor to tests (1.4.x) Slower hardware or VMs may have trouble completing tests within the timeouts specified. This change adds a -f option to run.py to add a scaling factor to the maxRuntime for tests, the timeout for Accumulo to shut down, and to specific timeouts in SimpleBalancerFairness and ZooCacheTest. Compare to a similar change for ACCUMULO-1789 . Signed-off-by: Eric Newton <eric.newton@gmail.com>

            People

            • Assignee:
              Bill Havanki
              Reporter:
              Bill Havanki
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development