Uploaded image for project: 'Accumulo'
  1. Accumulo
  2. ACCUMULO-1698

stop-here doesn't consider system hostname

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.4.3, 1.5.0
    • Fix Version/s: 1.4.5, 1.5.1, 1.6.0
    • Component/s: scripts
    • Labels:
      None
    • Environment:

      CentOS release 6.4 (Final)

      Description

      On poorly configured systems where the hostname doesn't appear in /etc/hosts, a proper hostname isn't always obtained by stop-here.sh, as a result accumulo admin stop won't be issued before killing local services.

      [alexm@r03n39 ~]$ hostname
      r03n39.demo
      [alexm@r03n39 ~]$ grep r03n39.demo /etc/hosts
      [alexm@r03n39 ~]$ hostname -a
      
      [alexm@r03n39 ~]$
      

      start-here has slightly expanded search for valid hostname

      1. ACCUMULO-1698.1.patch.txt
        0.8 kB
        Alex Moundalexis
      2. ACCUMULO-1698.2.patch.txt
        0.7 kB
        Alex Moundalexis

        Activity

        Hide
        _alexm Alex Moundalexis added a comment -

        Simple patch based on logic in start-here script. Verified on original environment.

        Show
        _alexm Alex Moundalexis added a comment - Simple patch based on logic in start-here script. Verified on original environment.
        Hide
        _alexm Alex Moundalexis added a comment -

        Patch for 1.4.5-SNAPSHOT, previous was for master.

        Show
        _alexm Alex Moundalexis added a comment - Patch for 1.4.5-SNAPSHOT, previous was for master.
        Hide
        busbey Sean Busbey added a comment -

        Any reason not to include the "localhost" fall back from start-here.sh (1.4.5-SNAPSHOT, 1.5.1-SNAPSHOT, and master)? Or the fall back to ips (1.5.1-SNAPSHOT, master)?

        Show
        busbey Sean Busbey added a comment - Any reason not to include the "localhost" fall back from start-here.sh (1.4.5-SNAPSHOT, 1.5.1-SNAPSHOT, and master)? Or the fall back to ips (1.5.1-SNAPSHOT, master)?
        Hide
        _alexm Alex Moundalexis added a comment -

        localhost fallback is covered by the first if case:

        if grep -q localhost $ACCUMULO_HOME/conf/slaves
        
        Show
        _alexm Alex Moundalexis added a comment - localhost fallback is covered by the first if case: if grep -q localhost $ACCUMULO_HOME/conf/slaves
        Hide
        busbey Sean Busbey added a comment -

        ah yes, fair enough. Worth folding that into the single loop as start-here does? It would simplify things longer term.

        Show
        busbey Sean Busbey added a comment - ah yes, fair enough. Worth folding that into the single loop as start-here does? It would simplify things longer term.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit ac4a027b42ebe66fd184f8b0792272e4bdb86f8e in branch refs/heads/1.4.5-SNAPSHOT from Alex Moundalexis
        [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=ac4a027 ]

        ACCUMULO-1698, have stop-here use system+aliased hostname

        Signed-off-by: Josh Elser <elserj@apache.org>

        Show
        jira-bot ASF subversion and git services added a comment - Commit ac4a027b42ebe66fd184f8b0792272e4bdb86f8e in branch refs/heads/1.4.5-SNAPSHOT from Alex Moundalexis [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=ac4a027 ] ACCUMULO-1698 , have stop-here use system+aliased hostname Signed-off-by: Josh Elser <elserj@apache.org>
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit cd135831c5c4005129c652384cfdd3711c4b2f64 in branch refs/heads/1.5.1-SNAPSHOT from Josh Elser
        [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=cd13583 ]

        ACCUMULO-1698 Merge branch '1.4.5-SNAPSHOT' into 1.5.1-SNAPSHOT

        Conflicts:
        bin/stop-here.sh

        Show
        jira-bot ASF subversion and git services added a comment - Commit cd135831c5c4005129c652384cfdd3711c4b2f64 in branch refs/heads/1.5.1-SNAPSHOT from Josh Elser [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=cd13583 ] ACCUMULO-1698 Merge branch '1.4.5-SNAPSHOT' into 1.5.1-SNAPSHOT Conflicts: bin/stop-here.sh
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit ac4a027b42ebe66fd184f8b0792272e4bdb86f8e in branch refs/heads/1.5.1-SNAPSHOT from Alex Moundalexis
        [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=ac4a027 ]

        ACCUMULO-1698, have stop-here use system+aliased hostname

        Signed-off-by: Josh Elser <elserj@apache.org>

        Show
        jira-bot ASF subversion and git services added a comment - Commit ac4a027b42ebe66fd184f8b0792272e4bdb86f8e in branch refs/heads/1.5.1-SNAPSHOT from Alex Moundalexis [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=ac4a027 ] ACCUMULO-1698 , have stop-here use system+aliased hostname Signed-off-by: Josh Elser <elserj@apache.org>
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 63c5d64cbc8ae30d06da84bb36324eca38fc0e36 in branch refs/heads/master from Josh Elser
        [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=63c5d64 ]

        ACCUMULO-1698 Merge branch '1.5.1-SNAPSHOT'

        Show
        jira-bot ASF subversion and git services added a comment - Commit 63c5d64cbc8ae30d06da84bb36324eca38fc0e36 in branch refs/heads/master from Josh Elser [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=63c5d64 ] ACCUMULO-1698 Merge branch '1.5.1-SNAPSHOT'
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit cd135831c5c4005129c652384cfdd3711c4b2f64 in branch refs/heads/master from Josh Elser
        [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=cd13583 ]

        ACCUMULO-1698 Merge branch '1.4.5-SNAPSHOT' into 1.5.1-SNAPSHOT

        Conflicts:
        bin/stop-here.sh

        Show
        jira-bot ASF subversion and git services added a comment - Commit cd135831c5c4005129c652384cfdd3711c4b2f64 in branch refs/heads/master from Josh Elser [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=cd13583 ] ACCUMULO-1698 Merge branch '1.4.5-SNAPSHOT' into 1.5.1-SNAPSHOT Conflicts: bin/stop-here.sh
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit ac4a027b42ebe66fd184f8b0792272e4bdb86f8e in branch refs/heads/master from Alex Moundalexis
        [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=ac4a027 ]

        ACCUMULO-1698, have stop-here use system+aliased hostname

        Signed-off-by: Josh Elser <elserj@apache.org>

        Show
        jira-bot ASF subversion and git services added a comment - Commit ac4a027b42ebe66fd184f8b0792272e4bdb86f8e in branch refs/heads/master from Alex Moundalexis [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=ac4a027 ] ACCUMULO-1698 , have stop-here use system+aliased hostname Signed-off-by: Josh Elser <elserj@apache.org>
        Hide
        elserj Josh Elser added a comment -

        Applied! Thanks, Alex.

        Show
        elserj Josh Elser added a comment - Applied! Thanks, Alex.

          People

          • Assignee:
            _alexm Alex Moundalexis
            Reporter:
            _alexm Alex Moundalexis
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development