Accumulo
  1. Accumulo
  2. ACCUMULO-1556

Initialize could use a better warning when HDFS dir is already populated

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.4.4, 1.5.0
    • Fix Version/s: 1.4.5, 1.5.1, 1.6.0
    • Component/s: client
    • Labels:
      None

      Description

      When attempting to initialize Accumulo and the instance.dfs.dir is pointing at a directory in HDFS which has already been initialized, you get a very undescriptive warning message which doesn't actually say refer to the fact that this is an HDFS directory.

      [util.Initialize] FATAL: It appears this location was previously initialized, exiting ... 
      

      It would be better to be explicit and tell the user that their $instance.dfs.dir value already has been initialized in HDFS instead of leaving that up to the user to discern.

      1. ACCUMULO-1556-master.patch
        13 kB
        Bill Havanki
      2. ACCUMULO-1556-1.5.patch
        13 kB
        Bill Havanki
      3. ACCUMULO-1556.patch
        14 kB
        Bill Havanki

        Issue Links

          Activity

          Hide
          Bill Havanki added a comment -
          Show
          Bill Havanki added a comment - Review available: https://reviews.apache.org/r/15279/
          Hide
          Bill Havanki added a comment -

          Patch based on 1.4.5-SNAPSHOT.

          Show
          Bill Havanki added a comment - Patch based on 1.4.5-SNAPSHOT.
          Hide
          Eric Newton added a comment -

          Bill Havanki the merge from 1.4 to 1.5 isn't going trivially for me. Can you post a 1.5-based patch, too?

          Show
          Eric Newton added a comment - Bill Havanki the merge from 1.4 to 1.5 isn't going trivially for me. Can you post a 1.5-based patch, too?
          Hide
          Bill Havanki added a comment -

          Sure, I'll get to work on that.

          Show
          Bill Havanki added a comment - Sure, I'll get to work on that.
          Hide
          Bill Havanki added a comment -

          ACCUMULO-1556-1.5.patch is the patch for 1.5.1-SNAPSHOT.

          Differences:

          • easymock is already in dependency management for 1.5.x
          • IZooReaderWriter moved from server to fate, needed to fix unit test
          Show
          Bill Havanki added a comment - ACCUMULO-1556 -1.5.patch is the patch for 1.5.1-SNAPSHOT. Differences: easymock is already in dependency management for 1.5.x IZooReaderWriter moved from server to fate, needed to fix unit test
          Hide
          Mike Drob added a comment - - edited

          Is this impacted by ACCUMULO-1747?

          Edit: And ACCUMULO-118?

          Show
          Mike Drob added a comment - - edited Is this impacted by ACCUMULO-1747 ? Edit: And ACCUMULO-118 ?
          Hide
          John Vines added a comment -

          Sorry Bill Havanki, I also need a revised patch for master, as it was also non trivial. I got the compile warnings resolved, but can't quite get the test passing, most likely to my lack of understanding of easymock.

          Show
          John Vines added a comment - Sorry Bill Havanki , I also need a revised patch for master, as it was also non trivial. I got the compile warnings resolved, but can't quite get the test passing, most likely to my lack of understanding of easymock.
          Hide
          Bill Havanki added a comment -

          No worries, I'll get on that.

          Show
          Bill Havanki added a comment - No worries, I'll get on that.
          Hide
          Bill Havanki added a comment -

          Created patch for master branch by John Vines's request. Posted for review to double-check myself.

          Show
          Bill Havanki added a comment - Created patch for master branch by John Vines 's request. Posted for review to double-check myself.
          Hide
          Bill Havanki added a comment -

          Patch for master, reviewed.

          Show
          Bill Havanki added a comment - Patch for master, reviewed.
          Hide
          ASF subversion and git services added a comment -

          Commit 1b3d071a8b46617245a39d039a2fe9e31600fc2e in branch refs/heads/1.4.5-SNAPSHOT from Bill Havanki
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=1b3d071 ]

          ACCUMULO-1556 Clarify initialization error for used fs

          The Initialize class now generates clearer and more informative
          error messages if an initialized instance is discovered. The
          messages vary depending on whether instance.dfs.uri is used. The
          values of instance.dfs.uri and instance.dfs.dir are also logged.

          Show
          ASF subversion and git services added a comment - Commit 1b3d071a8b46617245a39d039a2fe9e31600fc2e in branch refs/heads/1.4.5-SNAPSHOT from Bill Havanki [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=1b3d071 ] ACCUMULO-1556 Clarify initialization error for used fs The Initialize class now generates clearer and more informative error messages if an initialized instance is discovered. The messages vary depending on whether instance.dfs.uri is used. The values of instance.dfs.uri and instance.dfs.dir are also logged.
          Hide
          ASF subversion and git services added a comment -

          Commit 1b3d071a8b46617245a39d039a2fe9e31600fc2e in branch refs/heads/1.5.1-SNAPSHOT from Bill Havanki
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=1b3d071 ]

          ACCUMULO-1556 Clarify initialization error for used fs

          The Initialize class now generates clearer and more informative
          error messages if an initialized instance is discovered. The
          messages vary depending on whether instance.dfs.uri is used. The
          values of instance.dfs.uri and instance.dfs.dir are also logged.

          Show
          ASF subversion and git services added a comment - Commit 1b3d071a8b46617245a39d039a2fe9e31600fc2e in branch refs/heads/1.5.1-SNAPSHOT from Bill Havanki [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=1b3d071 ] ACCUMULO-1556 Clarify initialization error for used fs The Initialize class now generates clearer and more informative error messages if an initialized instance is discovered. The messages vary depending on whether instance.dfs.uri is used. The values of instance.dfs.uri and instance.dfs.dir are also logged.
          Hide
          ASF subversion and git services added a comment -

          Commit 07fa748e0f25acc59c76ca04fc37f84d84d3b12e in branch refs/heads/1.5.1-SNAPSHOT from Bill Havanki
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=07fa748 ]

          ACCUMULO-1556 Clarify initialization error for used fs

          The Initialize class now generates clearer and more informative
          error messages if an initialized instance is discovered. The
          messages vary depending on whether instance.dfs.uri is used. The
          values of instance.dfs.uri and instance.dfs.dir are also logged.

          Show
          ASF subversion and git services added a comment - Commit 07fa748e0f25acc59c76ca04fc37f84d84d3b12e in branch refs/heads/1.5.1-SNAPSHOT from Bill Havanki [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=07fa748 ] ACCUMULO-1556 Clarify initialization error for used fs The Initialize class now generates clearer and more informative error messages if an initialized instance is discovered. The messages vary depending on whether instance.dfs.uri is used. The values of instance.dfs.uri and instance.dfs.dir are also logged.
          Hide
          ASF subversion and git services added a comment -

          Commit 1b3d071a8b46617245a39d039a2fe9e31600fc2e in branch refs/heads/1.6.0-SNAPSHOT from Bill Havanki
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=1b3d071 ]

          ACCUMULO-1556 Clarify initialization error for used fs

          The Initialize class now generates clearer and more informative
          error messages if an initialized instance is discovered. The
          messages vary depending on whether instance.dfs.uri is used. The
          values of instance.dfs.uri and instance.dfs.dir are also logged.

          Show
          ASF subversion and git services added a comment - Commit 1b3d071a8b46617245a39d039a2fe9e31600fc2e in branch refs/heads/1.6.0-SNAPSHOT from Bill Havanki [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=1b3d071 ] ACCUMULO-1556 Clarify initialization error for used fs The Initialize class now generates clearer and more informative error messages if an initialized instance is discovered. The messages vary depending on whether instance.dfs.uri is used. The values of instance.dfs.uri and instance.dfs.dir are also logged.
          Hide
          ASF subversion and git services added a comment -

          Commit 07fa748e0f25acc59c76ca04fc37f84d84d3b12e in branch refs/heads/1.6.0-SNAPSHOT from Bill Havanki
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=07fa748 ]

          ACCUMULO-1556 Clarify initialization error for used fs

          The Initialize class now generates clearer and more informative
          error messages if an initialized instance is discovered. The
          messages vary depending on whether instance.dfs.uri is used. The
          values of instance.dfs.uri and instance.dfs.dir are also logged.

          Show
          ASF subversion and git services added a comment - Commit 07fa748e0f25acc59c76ca04fc37f84d84d3b12e in branch refs/heads/1.6.0-SNAPSHOT from Bill Havanki [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=07fa748 ] ACCUMULO-1556 Clarify initialization error for used fs The Initialize class now generates clearer and more informative error messages if an initialized instance is discovered. The messages vary depending on whether instance.dfs.uri is used. The values of instance.dfs.uri and instance.dfs.dir are also logged.
          Hide
          ASF subversion and git services added a comment -

          Commit 31b58c473d4abd4c7a9f51c558bdc89b61a92bfe in branch refs/heads/1.6.0-SNAPSHOT from Bill Havanki
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=31b58c4 ]

          ACCUMULO-1556 Clarify initialization error for used fs

          The Initialize class now generates clearer and more informative
          error messages if an initialized instance is discovered. The
          messages vary depending on whether instance.dfs.uri is used. The
          values of instance.dfs.uri and instance.dfs.dir are also logged.

          Show
          ASF subversion and git services added a comment - Commit 31b58c473d4abd4c7a9f51c558bdc89b61a92bfe in branch refs/heads/1.6.0-SNAPSHOT from Bill Havanki [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=31b58c4 ] ACCUMULO-1556 Clarify initialization error for used fs The Initialize class now generates clearer and more informative error messages if an initialized instance is discovered. The messages vary depending on whether instance.dfs.uri is used. The values of instance.dfs.uri and instance.dfs.dir are also logged.
          Hide
          ASF subversion and git services added a comment -

          Commit 07fa748e0f25acc59c76ca04fc37f84d84d3b12e in branch refs/heads/master from Bill Havanki
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=07fa748 ]

          ACCUMULO-1556 Clarify initialization error for used fs

          The Initialize class now generates clearer and more informative
          error messages if an initialized instance is discovered. The
          messages vary depending on whether instance.dfs.uri is used. The
          values of instance.dfs.uri and instance.dfs.dir are also logged.

          Show
          ASF subversion and git services added a comment - Commit 07fa748e0f25acc59c76ca04fc37f84d84d3b12e in branch refs/heads/master from Bill Havanki [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=07fa748 ] ACCUMULO-1556 Clarify initialization error for used fs The Initialize class now generates clearer and more informative error messages if an initialized instance is discovered. The messages vary depending on whether instance.dfs.uri is used. The values of instance.dfs.uri and instance.dfs.dir are also logged.
          Hide
          ASF subversion and git services added a comment -

          Commit 31b58c473d4abd4c7a9f51c558bdc89b61a92bfe in branch refs/heads/master from Bill Havanki
          [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=31b58c4 ]

          ACCUMULO-1556 Clarify initialization error for used fs

          The Initialize class now generates clearer and more informative
          error messages if an initialized instance is discovered. The
          messages vary depending on whether instance.dfs.uri is used. The
          values of instance.dfs.uri and instance.dfs.dir are also logged.

          Show
          ASF subversion and git services added a comment - Commit 31b58c473d4abd4c7a9f51c558bdc89b61a92bfe in branch refs/heads/master from Bill Havanki [ https://git-wip-us.apache.org/repos/asf?p=accumulo.git;h=31b58c4 ] ACCUMULO-1556 Clarify initialization error for used fs The Initialize class now generates clearer and more informative error messages if an initialized instance is discovered. The messages vary depending on whether instance.dfs.uri is used. The values of instance.dfs.uri and instance.dfs.dir are also logged.
          Hide
          John Vines added a comment -

          Thanks for the patch(es)!

          Show
          John Vines added a comment - Thanks for the patch(es)!
          Hide
          John Vines added a comment -

          Please close the review board entry when you get a chance

          Show
          John Vines added a comment - Please close the review board entry when you get a chance

            People

            • Assignee:
              Bill Havanki
              Reporter:
              Miguel Pereira
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development