Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.5.0
    • Fix Version/s: 1.6.0
    • Component/s: shell
    • Labels:
      None

      Description

      JLine looks like it hasn't see any updates since 2007, and has some serious limitations. However, it's there is a clone with active support at https://github.com/jline/jline2

      It might be reasonable to investigate switching.

      1. ACCUMULO-1442-v1.patch
        62 kB
        Mike Drob
      2. ACCUMULO-1442-v2.patch
        69 kB
        Mike Drob
      3. ACCUMULO-1442-v3.patch
        70 kB
        Mike Drob

        Issue Links

          Activity

          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 1492440 from Christopher Tubbs
          [ https://svn.apache.org/r1492440 ]

          ACCUMULO-1442 Use latest JLine2

          Show
          jira-bot ASF subversion and git services added a comment - Commit 1492440 from Christopher Tubbs [ https://svn.apache.org/r1492440 ] ACCUMULO-1442 Use latest JLine2
          Hide
          mdrob Mike Drob added a comment -

          Trunk looks good to go. Thanks, Billie!

          Show
          mdrob Mike Drob added a comment - Trunk looks good to go. Thanks, Billie!
          Hide
          billie.rinaldi Billie Rinaldi added a comment -

          I tested it out on a Mac and spun up the ShellServlet. Things appeared to work. There were a handful of tabs in the patch, and I removed them.

          Show
          billie.rinaldi Billie Rinaldi added a comment - I tested it out on a Mac and spun up the ShellServlet. Things appeared to work. There were a handful of tabs in the patch, and I removed them.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 1488407 from Billie Rinaldi
          [ https://svn.apache.org/r1488407 ]

          ACCUMULO-1442 committed Mike Drob's patch to upgrade to jline 2

          Show
          jira-bot ASF subversion and git services added a comment - Commit 1488407 from Billie Rinaldi [ https://svn.apache.org/r1488407 ] ACCUMULO-1442 committed Mike Drob's patch to upgrade to jline 2
          Hide
          mdrob Mike Drob added a comment -

          Can somebody on a Mac test ACCUMULO-1442-v3.patch and let me know if there are any issues?

          Show
          mdrob Mike Drob added a comment - Can somebody on a Mac test ACCUMULO-1442-v3.patch and let me know if there are any issues?
          Hide
          mdrob Mike Drob added a comment -

          Cancelled the patch thinking I had run into a bug under windows, but it looks like there is not a great fix. Potentially similar issue at https://jira.codehaus.org/browse/JRUBY-6587

          Show
          mdrob Mike Drob added a comment - Cancelled the patch thinking I had run into a bug under windows, but it looks like there is not a great fix. Potentially similar issue at https://jira.codehaus.org/browse/JRUBY-6587
          Hide
          mdrob Mike Drob added a comment -

          Patch 3 applies to trunk. The changes from this will ripple to ACCUMULO-1399 and possibly others.

          Show
          mdrob Mike Drob added a comment - Patch 3 applies to trunk. The changes from this will ripple to ACCUMULO-1399 and possibly others.
          Hide
          mdrob Mike Drob added a comment -

          Patch applies to 1.5 branch with -p1.

          A few notes:

          • I had to disable history events, because it would try to expand !METADATA and fail. Thinking about other workarounds, but haven't really come up with anything.
          • I wasn't able to test the ShellServer beyond the unit tests, I would appreciate somebody else giving it a once-over as well.
          Show
          mdrob Mike Drob added a comment - Patch applies to 1.5 branch with -p1 . A few notes: I had to disable history events, because it would try to expand !METADATA and fail. Thinking about other workarounds, but haven't really come up with anything. I wasn't able to test the ShellServer beyond the unit tests, I would appreciate somebody else giving it a once-over as well.
          Hide
          mdrob Mike Drob added a comment -

          Never mind, figured out how to get around this. Not my proudest code, but I'll have another cleaned up patch available later today.

          Show
          mdrob Mike Drob added a comment - Never mind, figured out how to get around this. Not my proudest code, but I'll have another cleaned up patch available later today.
          Hide
          mdrob Mike Drob added a comment -

          Patch applies to 1.5 branch with -p1

          Show
          mdrob Mike Drob added a comment - Patch applies to 1.5 branch with -p1
          Hide
          mdrob Mike Drob added a comment -

          Attaching a patch that is a first cut at making the switch. jline2 has a lot nicer APIs for the most part, but they're not strictly compatible.

          Most methods had one-for-one replacements, however I could not figure out how to get ShellServerTest to work. Billie Rinaldi - care to take a look?

          Show
          mdrob Mike Drob added a comment - Attaching a patch that is a first cut at making the switch. jline2 has a lot nicer APIs for the most part, but they're not strictly compatible. Most methods had one-for-one replacements, however I could not figure out how to get ShellServerTest to work. Billie Rinaldi - care to take a look?
          Show
          billie.rinaldi Billie Rinaldi added a comment - http://www.apache.org/legal/resolved.html#category-a
          Hide
          ctubbsii Christopher Tubbs added a comment -

          jline v2 BSD license is the same as jline v1, and should be fine

          Show
          ctubbsii Christopher Tubbs added a comment - jline v2 BSD license is the same as jline v1, and should be fine
          Hide
          mdrob Mike Drob added a comment -

          Billie Rinaldi - JLine2 is BSD Licensed. Google tells me that is Apache friendly, but I can't find an Official statement on it. Can you point me at something that definitive?

          Show
          mdrob Mike Drob added a comment - Billie Rinaldi - JLine2 is BSD Licensed. Google tells me that is Apache friendly, but I can't find an Official statement on it. Can you point me at something that definitive?

            People

            • Assignee:
              mdrob Mike Drob
              Reporter:
              mdrob Mike Drob
            • Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development