[ABDERA-231] NullPointerException in RequestOptions.addHeader() when no previous header with that name has been set

• Type: Bug
• Status: Reopened
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 0.4.0
• Environment: All
• Assignee: Unassigned
• Reporter: Jon Hewitt
• Created: 08/May/09 12:53
• Updated: 21/Nov/12 23:57

Description

This code snippet recreates the problem.
RequestOptions requestOptions = client.getDefaultRequestOptions();
requestOptions.addHeader("Cookie", "anyNonNullValue");

Caused by: java.lang.NullPointerException
at java.util.Arrays$ArrayList.<init>(Arrays.java:2370)
at java.util.Arrays.asList(Arrays.java:2356)
at org.apache.abdera.protocol.client.RequestOptions.addHeader(RequestOptions.java:272)
at org.apache.abdera.protocol.client.RequestOptions.addHeader(RequestOptions.java:263)

It looks like that RequestOptions.addEncodedHeader() also has the same problem of calling Arrays.asList() before checking for returned null value from getHeaders().get(header)

One can workaround the problem by calling getHeader() to see if the header has previous values. If it doesn't, just call setHeader().

This is a regression - addHeader() works fine in 0.2.2.