Abdera
  1. Abdera
  2. ABDERA-146

Bad entry edit link created in my server when using a provider base path

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.4.0
    • Fix Version/s: 1.0
    • Labels:
      None

      Description

      My Abdera servlet is not mapped to the root of my application context. It is mapped to /atom/*, so that my application context can host multiple servlets and a static HTML site at the root path.

      Thus, I create my provider with a base of /atom/. This in turn creates the following route: /atom/:collection/:entry

      When I GET an entry, the resolving part goes well. However, the generated edit link for this entry duplicates the base part of the URI.

      RouteManager.urlFor(RequestContext, Object, Object) line: 158
      SpringProvider(AbstractProvider).urlFor(RequestContext, Object, Object) line: 102
      ServletRequestContext(AbstractRequestContext).urlFor(Object, Object) line: 184
      MovieAdapter(AbstractCollectionAdapter).getHref(RequestContext) line: 82
      MovieAdapter(AbstractEntityCollectionAdapter<T>).getFeedIriForEntry(T, RequestContext) line: 548
      MovieAdapter(AbstractEntityCollectionAdapter<T>).getEntryFromCollectionProvider(RequestContext) line: 721
      MovieAdapter(AbstractEntityCollectionAdapter<T>).getEntry(RequestContext) line: 316
      SpringProvider(AbstractProvider).process(RequestContext) line: 155

      The last stack frame (urlFor) is where I believe the error is. The route expands properly and includes the provider base path. However, the getTargetBasePath() call concatenates the application context with the servlet path, the servlet path being equal to the provider base path.

      Real values used in my tests:

      application context: /imdb
      provider base: /atom/
      adapter href: movies
      GET URI: http://localhost:8080/imdb/atom/movies/12345

      The generated edit URI is: http://localhost:8080/imdb/atom/atom/movies/12345

      Thanks for looking into this.

      Remy

      1. DefaultWorkspaceManager.patch
        0.7 kB
        Remy Gendron
      2. route_manager.patch
        3 kB
        David Calavera

        Activity

        Hide
        David Calavera added a comment -

        I'm not sure if this is correct, but I think that the RouteManager class should use the contextPath instead of the targetBasePath in order to create the url for the route.

        Show
        David Calavera added a comment - I'm not sure if this is correct, but I think that the RouteManager class should use the contextPath instead of the targetBasePath in order to create the url for the route.
        Hide
        Remy Gendron added a comment -

        David, your fix is OK I think for the RouteManager itself.

        However, there was still an issue in the DefaultWorkspaceManager. Following the fix in the RouteManager, the workspace could no longer find the requested adapter as now the two paths would not match.

        I am proposing a patch for the DefaultWorkspaceManager. With it, all of my unit tests are green in the four combinations of root servlet path/specific servlet path and root application context/specific application context.

        I think this needs to be included in the 0.4.0 branch if it is to become an RC1.

        Thanks again David.

        Show
        Remy Gendron added a comment - David, your fix is OK I think for the RouteManager itself. However, there was still an issue in the DefaultWorkspaceManager. Following the fix in the RouteManager, the workspace could no longer find the requested adapter as now the two paths would not match. I am proposing a patch for the DefaultWorkspaceManager. With it, all of my unit tests are green in the four combinations of root servlet path/specific servlet path and root application context/specific application context. I think this needs to be included in the 0.4.0 branch if it is to become an RC1. Thanks again David.
        Hide
        Dan Diephouse added a comment -

        Thanks for the patches. I've applied these in: http://svn.apache.org/viewvc?rev=649280&view=rev

        Show
        Dan Diephouse added a comment - Thanks for the patches. I've applied these in: http://svn.apache.org/viewvc?rev=649280&view=rev

          People

          • Assignee:
            Dan Diephouse
            Reporter:
            Remy Gendron
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development