Bug 55435 - ComboStringEditor could be simplified to make most settings final
ComboStringEditor could be simplified to make most settings final
Status: RESOLVED FIXED
Product: JMeter
Classification: Unclassified
Component: Main
2.9
PC Windows XP
: P2 enhancement (vote)
: ---
Assigned To: JMeter issues mailing list
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2013-08-16 17:55 UTC by Sebb
Modified: 2013-08-16 18:04 UTC (History)
0 users



Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sebb 2013-08-16 17:55:44 UTC
The package-private ComboStringEditor can be reconfigured to change the tags, edit and undefined behaviour after creation. 

This makes the code more complicated than it needs to be. Currently JMeter does not change the settings after the class has been created, so it could be simplified by removing the setTags(), setNoEdit() and setNoUndefined() methods, replacing them with constructor parameters.
Comment 1 Sebb 2013-08-16 18:04:42 UTC
URL: http://svn.apache.org/r1514823
Log:
ComboStringEditor could be simplified to make most settings final
Bugzilla Id: 55435

Modified:
    jmeter/trunk/src/core/org/apache/jmeter/testbeans/gui/ComboStringEditor.java
    jmeter/trunk/src/core/org/apache/jmeter/testbeans/gui/FileEditor.java
    jmeter/trunk/src/core/org/apache/jmeter/testbeans/gui/GenericTestBeanCustomizer.java
    jmeter/trunk/xdocs/changes.xml