Bug 55411 - NativeCommand could be useful elsewhere
Summary: NativeCommand could be useful elsewhere
Status: RESOLVED FIXED
Alias: None
Product: JMeter - Now in Github
Classification: Unclassified
Component: Main (show other bugs)
Version: 2.9
Hardware: PC Windows XP
: P2 enhancement (vote)
Target Milestone: ---
Assignee: JMeter issues mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-13 09:22 UTC by Sebb
Modified: 2013-08-13 09:46 UTC (History)
0 users


Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sebb 2013-08-13 09:22:13 UTC 
The NativeCommand functionality could be useful elsewhere in JMeter.

The processing could be extracted and moved under the jorphan package (with suitable renaming).

To maintain compatibility, a public wrapper could be retained in the original location.
Comment 1 Sebb 2013-08-13 09:38:48 UTC 
URL: http://svn.apache.org/r1513407
Log:
NativeCommand could be useful elsewhere
Moved code to o.a.jorphan.exec
Bugzilla Id: 55411

Added:
    jmeter/trunk/src/jorphan/org/apache/jorphan/exec/
    jmeter/trunk/src/jorphan/org/apache/jorphan/exec/NativeCommand.java   (with props)
    jmeter/trunk/src/jorphan/org/apache/jorphan/exec/StreamCopier.java
      - copied, changed from r1507501, jmeter/trunk/src/protocol/native/org/apache/jmeter/protocol/system/StreamCopier.java
    jmeter/trunk/src/jorphan/org/apache/jorphan/exec/StreamGobbler.java
      - copied, changed from r1507501, jmeter/trunk/src/protocol/native/org/apache/jmeter/protocol/system/StreamGobbler.java
Removed:
    jmeter/trunk/src/protocol/native/org/apache/jmeter/protocol/system/StreamCopier.java
    jmeter/trunk/src/protocol/native/org/apache/jmeter/protocol/system/StreamGobbler.java
Modified:
    jmeter/trunk/src/protocol/native/org/apache/jmeter/protocol/system/NativeCommand.java
    jmeter/trunk/xdocs/changes.xml
Comment 2 Sebb 2013-08-13 09:46:39 UTC 
URL: http://svn.apache.org/r1513410
Log:
NativeCommand could be useful elsewhere
Deprecate original class
Rename new class to avoid confusion
Bugzilla Id: 55411

Added:
    jmeter/trunk/src/jorphan/org/apache/jorphan/exec/SystemCommand.java
      - copied, changed from r1513407, jmeter/trunk/src/jorphan/org/apache/jorphan/exec/NativeCommand.java
Removed:
    jmeter/trunk/src/jorphan/org/apache/jorphan/exec/NativeCommand.java
Modified:
    jmeter/trunk/src/protocol/native/org/apache/jmeter/protocol/system/NativeCommand.java
    jmeter/trunk/src/protocol/native/org/apache/jmeter/protocol/system/SystemSampler.java
Comment 3 The ASF infrastructure team 2022-09-24 20:37:54 UTC 
This issue has been migrated to GitHub: https://github.com/apache/jmeter/issues/3187