Bug 54841 - Correctly handle the quit shortcut on Mac Os (CMD-Q)
Correctly handle the quit shortcut on Mac Os (CMD-Q)
Status: RESOLVED FIXED
Product: JMeter
Classification: Unclassified
Component: Main
2.9
Macintosh Mac System 7
: P2 minor (vote)
: ---
Assigned To: JMeter issues mailing list
: PatchAvailable
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2013-04-13 22:00 UTC by benoit.wiart
Modified: 2013-04-14 13:43 UTC (History)
1 user (show)



Attachments
patch (644 bytes, patch)
2013-04-13 22:00 UTC, benoit.wiart
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description benoit.wiart 2013-04-13 22:00:27 UTC
Created attachment 30191 [details]
patch

On Mac Os the CMD-Q is not correctly intercepted, and jmeter doest not warn when the test plan has been modified (popup)
this patch use a system property as defined in :
https://developer.apple.com/library/mac/#releasenotes/Java/JavaSnowLeopardUpdate3LeopardUpdate8RN/NewandNoteworthy/NewandNoteworthy.html

tested on mac os 10.8.2
and java version "1.6.0_41"
Java(TM) SE Runtime Environment (build 1.6.0_41-b02-445-11M4107)
Java HotSpot(TM) 64-Bit Server VM (build 20.14-b01-445, mixed mode)

On Mac os we should also remove the 'exit' option of the file menu as 'Exit' is automatically added to the application Menu.
if the jmeter commiters accept to have some logic based on the os type : I'll provide another patch for the menu
Comment 1 Philippe Mouawad 2013-04-14 13:43:02 UTC
Date: Sun Apr 14 13:41:38 2013
New Revision: 1467775

URL: http://svn.apache.org/r1467775
Log:
Bug 54841 - Correctly handle the quit shortcut on Mac Os (CMD-Q)
Bugzilla Id: 54841

Modified:
    jmeter/trunk/bin/jmeter.sh
    jmeter/trunk/xdocs/changes.xml


Test OK on 10.6.8.
Applied, thanks for patch