Bug 54789 - XPath Assertion - GUI enhancements to increase readability and ease of use
XPath Assertion - GUI enhancements to increase readability and ease of use
Status: RESOLVED FIXED
Product: JMeter
Classification: Unclassified
Component: Main
2.9
All All
: P3 enhancement with 1 vote (vote)
: ---
Assigned To: JMeter issues mailing list
: PatchAvailable
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2013-04-02 17:58 UTC by Bruno Antunes
Modified: 2013-08-02 21:54 UTC (History)
1 user (show)



Attachments
Diff file with enhancements (2.17 KB, patch)
2013-04-02 17:58 UTC, Bruno Antunes
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bruno Antunes 2013-04-02 17:58:39 UTC
Created attachment 30137 [details]
Diff file with enhancements

Hello,

In my opinion, the XPath expression field in the XPath Assertion GUI could be defined as a TextArea.

I've attached a diff file with the following changes to src/components/org/apache/jmeter/assertions/gui/XPathPanel.java:
- XPathPanel class components changed from Box to BorderLayout
- "xpath" variable changed from JTextField to JLabeledTextArea


The diff file was created using TortoiseSVN 1.7.9 in Windows XP SP3


Best regards,
Bruno Antunes
Comment 1 Philippe Mouawad 2013-04-02 19:45:29 UTC
patch ends up creating a big Validate button, I don't find look better .
Comment 2 Bruno Antunes 2013-04-02 20:14:55 UTC
Yes, you're right, the button gets uglier. But with the current design it's very difficult to have a big (maybe multi line) XPath expression.

My main concern was the XPath expression and not the validate button. I just didn't have a better idea for the button. Maybe under the expression?
Comment 3 Philippe Mouawad 2013-08-02 21:54:35 UTC
Date: Fri Aug  2 21:53:41 2013
New Revision: 1509878

URL: http://svn.apache.org/r1509878
Log:
Bug 54789 - XPath Assertion - GUI enhancements to increase readability and ease of use
Bugzilla Id: 54789

Modified:
    jmeter/trunk/src/components/org/apache/jmeter/assertions/gui/XPathPanel.java
    jmeter/trunk/xdocs/changes.xml