Bug 54720 - [PATCH] Support for Row/Col Area Range like 8:8 or H:H
Summary: [PATCH] Support for Row/Col Area Range like 8:8 or H:H
Status: RESOLVED FIXED
Alias: None
Product: POI
Classification: Unclassified
Component: POI Overall (show other bugs)
Version: 3.10-dev
Hardware: PC All
: P2 enhancement (vote)
Target Milestone: ---
Assignee: POI Developers List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-18 13:43 UTC by opensource
Modified: 2013-08-16 17:37 UTC (History)
0 users


Attachments
patch for row area (13.81 KB, application/gzip)
2013-03-18 13:43 UTC, opensource 		Details
testdata (37.50 KB, application/vnd.ms-excel)
2013-03-18 13:44 UTC, opensource 		Details
patch for row area (13.81 KB, patch)
2013-03-18 14:13 UTC, opensource 		Details | Diff
patch for row area (13.81 KB, patch)
2013-03-18 14:41 UTC, opensource 		Details | Diff
patch for row area (13.81 KB, patch)
2013-03-18 14:51 UTC, opensource 		Details | Diff
patch for row area and col area (13.68 KB, patch)
2013-03-18 15:26 UTC, opensource 		Details | Diff
testdata (38.00 KB, patch)
2013-03-18 15:26 UTC, opensource 		Details | Diff
patch for row area and col area (13.34 KB, patch)
2013-03-18 15:31 UTC, opensource 		Details | Diff
testdata (38.00 KB, patch)
2013-03-18 15:31 UTC, opensource 		Details | Diff
Show Obsolete (7) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description opensource 2013-03-18 13:43:56 UTC 
Created attachment 30067 [details]
patch for row area

Issues explained

=INDIRECT("Indirect"&"!"&$H$3&":"&$H$3) is OK in POI when in cell H3 we have I3 as value (a reference to another cell)
=INDIRECT("Indirect"&"!"&$H$7&":"&$H$7) is failing in POI when H7=8 an integer 


What this patch is adding
Range support in the form of NameType.ROW:NameType.ROW 
like 8:8 or 6:8 

See testcase IndirectFunctionTestCaseData.xls

* new class org.apache.poi.ss.formula.functions.TestIndirectFunctionFromSpreadsheet
* new spreadsheet test-data\spreadsheet\IndirectFunctionTestCaseData.xls
* modified org.apache.poi.ss.formula.OperationEvaluationContext
Comment 1 opensource 2013-03-18 13:44:14 UTC 
Created attachment 30068 [details]
testdata
Comment 2 opensource 2013-03-18 14:13:42 UTC 
Created attachment 30069 [details]
patch for row area
Comment 3 opensource 2013-03-18 14:41:52 UTC 
Created attachment 30070 [details]
patch for row area
Comment 4 opensource 2013-03-18 14:51:48 UTC 
Created attachment 30071 [details]
patch for row area
Comment 5 opensource 2013-03-18 15:26:33 UTC 
Created attachment 30072 [details]
patch for row area and col area
Comment 6 opensource 2013-03-18 15:26:53 UTC 
Created attachment 30073 [details]
testdata
Comment 7 opensource 2013-03-18 15:27:57 UTC 
Patch now also support col area in the form of NameType.COLUMN:NameType.COLUMN like B:B  e,g

= INDIRECT("Indirect"&"!"&"B:B",TRUE)
Comment 8 opensource 2013-03-18 15:31:17 UTC 
Created attachment 30074 [details]
patch for row area and col area
Comment 9 opensource 2013-03-18 15:31:32 UTC 
Created attachment 30075 [details]
testdata
Comment 10 Cédric Walter 2013-08-16 17:37:21 UTC 
Commit #1514812