Bug 54267 - Start Next Thread Loop setting doesn't work in custom thread groups
Start Next Thread Loop setting doesn't work in custom thread groups
Status: RESOLVED FIXED
Product: JMeter
Classification: Unclassified
Component: Main
2.8
All All
: P2 normal (vote)
: ---
Assigned To: JMeter issues mailing list
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2012-12-08 11:53 UTC by Andrey Pohilko
Modified: 2012-12-08 12:42 UTC (History)
1 user (show)



Attachments
simple fix for the problem (863 bytes, patch)
2012-12-08 11:53 UTC, Andrey Pohilko
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Pohilko 2012-12-08 11:53:42 UTC
Created attachment 29729 [details]
simple fix for the problem

Users of JP@GC claming that setting "Start Next Thread Loop" has no effect in custom thread groups. Corresponding issue in JP@GC: http://code.google.com/p/jmeter-plugins/issues/detail?id=227

I investigated the reason and found that triggerEndOfLoopOnParentControllers method in JMeterThread uses not abstract class, and this causes custom thread groups not being processed.

I've attached a patch to fix this problem, startNextLoop method is a member of AbstractThreadGroup, I see no side effects.
Comment 1 Philippe Mouawad 2012-12-08 12:42:42 UTC
Date: Sat Dec  8 12:41:53 2012
New Revision: 1418661

URL: http://svn.apache.org/viewvc?rev=1418661&view=rev
Log:
Bug 54267 - Start Next Thread Loop setting doesn't work in custom thread groups
Bugzilla Id: 54267

Modified:
    jmeter/trunk/src/core/org/apache/jmeter/threads/JMeterThread.java
    jmeter/trunk/src/core/org/apache/jmeter/threads/gui/ThreadGroupGui.java
    jmeter/trunk/xdocs/changes.xml