When I run a test, and then switch language back to english, the stop/shutdown buttons are deactivated and the run-buttons are activated. The threads are still running though.
All my listerners got emptied, too.
Date: Sun Sep 7 19:17:09 2014 New Revision: 1623109 URL: http://svn.apache.org/r1623109 Log: Bug 54100 - Switching languages during test messes toolbar buttons state (enabled/disabled) Bugzilla Id: 54100 Modified: jmeter/trunk/src/core/org/apache/jmeter/gui/util/JMeterToolBar.java jmeter/trunk/xdocs/changes.xml
Only the toolbar issue has been fixed. Fixing the other issue with listener would be a big effort which is not worth the it. Date: Sun Sep 7 19:17:09 2014 New Revision: 1623109 URL: http://svn.apache.org/r1623109 Log: Bug 54100 - Switching languages during test messes toolbar buttons state (enabled/disabled) Bugzilla Id: 54100 Modified: jmeter/trunk/src/core/org/apache/jmeter/gui/util/JMeterToolBar.java jmeter/trunk/xdocs/changes.xml
Would it not be better to disable language change during a test? There does not seem to be a valid use-case for allowing it, and disallowing the change would solve the issue of the listeners being emptied.
Yes good idea. But isn't it better to open a bug linked with this one, as this one (as per title) has been fixed and will appear in 2.12 release notes.
Opened: https://issues.apache.org/bugzilla/show_bug.cgi?id=56927 To fix issue related to Listeners. Closing this one.
(In reply to Philippe Mouawad from comment #5) > Yes good idea. > But isn't it better to open a bug linked with this one, as this one (as per > title) has been fixed and will appear in 2.12 release notes. Why does it need a different issue? It's just a different way to solve this bug report. And the 2.12 release notes can be adjusted accordingly.
In fact I fixed in the commit a bug: "Switching languages messes toolbar" , it affected for example Undo/redo feature. Maybe I should have created a new bug at that time. What about renaming this bug to : "Switching languages messes toolbar buttons state (enabled/disabled)" And the new one I opened would be this one. When I do this it is so that any bug mentionned in changes.xml is closed in Bugzilla. I find it misleading to have the bug mentionned in changes.xml while it is still opened here.
(In reply to Philippe Mouawad from comment #8) > In fact I fixed in the commit a bug: > "Switching languages messes toolbar" , it affected for example Undo/redo > feature. > Maybe I should have created a new bug at that time. Depends on the bug wording. As originally written, it was only about language change during a test. However it turns out that the bug was true for any language change, but was not noticeable previously as the default settings are OK when no test is running. Undo/Redo exposed the bug outside a test. > What about renaming this bug to : > "Switching languages messes toolbar buttons state (enabled/disabled)" "Switching language fails to preserve toolbar button states (enabled/disabled)" > And the new one I opened would be this one. OK > > When I do this it is so that any bug mentionned in changes.xml is closed in > Bugzilla. > I find it misleading to have the bug mentionned in changes.xml while it is > still opened here. In that case, update changes.xml to remove the details or note that it as incomplete.
This issue has been migrated to GitHub: https://github.com/apache/jmeter/issues/2968