Bug 53924 - [PATCH] support for retrieve-table-marker
Summary: [PATCH] support for retrieve-table-marker
Status: RESOLVED FIXED
Alias: None
Product: Fop - Now in Jira
Classification: Unclassified
Component: general (show other bugs)
Version: trunk
Hardware: All All
: P2 enhancement
Target Milestone: ---
Assignee: fop-dev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-23 23:19 UTC by Luis Bernardo
Modified: 2012-09-28 15:26 UTC (History)
0 users



Attachments
patch (153.33 KB, patch)
2012-09-23 23:20 UTC, Luis Bernardo
Details | Diff
two extensive examples (57.46 KB, application/x-gzip)
2012-09-23 23:23 UTC, Luis Bernardo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Luis Bernardo 2012-09-23 23:19:55 UTC
This patch adds support for retrieve-table-marker. The patch is extensive and very likely there is room for improvement, but it does what it is supposed to do and was tested with non trivial examples.

The implementation has a main constraint: the resolution of the retrieve-table-marker element needs to be an element that does not change the BPD of the containing cell. In practical terms this means that the height of the table header or footer where the retrieve-table-marker element is placed cannot change once the retrieve-table-marker is replaced by the resolved content. In the end this is not a serious constraint since in most cases the retrieve-table-marker element is meant to be replaced by a line of text (and there is already adjacent text, or the height of the cell is specified).
Comment 1 Luis Bernardo 2012-09-23 23:20:52 UTC
Created attachment 29410 [details]
patch
Comment 2 Luis Bernardo 2012-09-23 23:23:37 UTC
Created attachment 29411 [details]
two extensive examples

two examples: include *.fo source and *.pdf output
Comment 3 Mehdi Houshmand 2012-09-28 15:26:36 UTC
Committed to r1391502. One thing to note, I haven't changed it this time because I'm not very familiar with the layout are of code, but adding comments like:
// mock
<then mocking something>
don't really add anything. It's obvious you're mocking, because you're using the mock(...) method. Not a biggy, but just for next time.

Thanks for the work, keep it up!

Mehdi