Bug 53841 - CSVSaveService reads file using JVM default file encoding instead of using the one configured in saveservice.properties
CSVSaveService reads file using JVM default file encoding instead of using th...
Status: RESOLVED FIXED
Product: JMeter
Classification: Unclassified
Component: Main
2.7
All All
: P2 normal (vote)
: ---
Assigned To: JMeter issues mailing list
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2012-09-07 21:24 UTC by Philippe Mouawad
Modified: 2012-09-08 08:32 UTC (History)
1 user (show)



Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Mouawad 2012-09-07 21:24:05 UTC
Currently, in CSVSaveService#processSamples, the reader is opened using default JVM file encoding as no encoding is passed, while configured _file_encoding (saveservice.properties) is used to write this file.

So this may cause problems as CSV writing will use different encoding (probably UTF-8 if no change has been made) than CSV reading corrupting potentially data passed to Visualizers (GraphVisualizer, RespTimeGraphVisualizer...)
Comment 1 Philippe Mouawad 2012-09-07 21:28:27 UTC
Date: Fri Sep  7 21:27:24 2012
New Revision: 1382180

URL: http://svn.apache.org/viewvc?rev=1382180&view=rev
Log:
Bug 53841 - CSVSaveService reads file using JVM default file encoding instead of using the one configured in saveservice.properties
Bugzilla Id: 53841

Modified:
    jmeter/trunk/bin/saveservice.properties
    jmeter/trunk/src/core/org/apache/jmeter/save/CSVSaveService.java
    jmeter/trunk/xdocs/changes.xml
Comment 2 Philippe Mouawad 2012-09-08 08:32:47 UTC
Date: Sat Sep  8 08:31:31 2012
New Revision: 1382248

URL: http://svn.apache.org/viewvc?rev=1382248&view=rev
Log:
Bug 53841 - CSVSaveService reads file using JVM default file encoding instead of using the one configured in saveservice.properties

Fix test failure and clarify failure message
Bugzilla Id: 53841

Modified:
    jmeter/trunk/src/core/org/apache/jmeter/save/SaveService.java
    jmeter/trunk/test/src/org/apache/jmeter/save/TestSaveService.java