Created attachment 29026 [details] Code changes which now conform to the AFP specification for end structured fields When trying to use an AFP image without a matching end structured field ID, an error (Array index out of bounds) would occur. The MODCA specification [1] states that the end structured field is valid in the following three states: - An end structured field has no matching end tag id. In which case it will match the last tag found - The end tag ends with a FF FF value which, similar to no name will match any opening tag. - A matching id on both start and end tags which is the usual case. I have updated the code to support all three of these cases and now images are loaded successfully when generating an AFP document should one of these other two cases arise. These same rules also apply to all other structured field types and the code change will support these. I have also added four new test cases which utilize four AFP images covering each case above including a name mismatch (which is expected to throw an exception). These will be attached to this patch shortly. Please note, as listed in the patch these *.afp test files should go in test/java/org/apache/fop/afp/ along with the AFPResourceUtilTestCase.java file changes. I will also add a fail example to this patch to show an example of it breaking. [1] http://www.outputlinks.com/SpecialInterest/AFPColorConsortium/mo_dca_reference.pdf
Created attachment 29027 [details] AFP test files zip attached need to be extracted to test/java/org/apache/fop/afp/
Created attachment 29028 [details] Example fail test case Added a fail test case showing the issue. Generate AFP to see the error.
This has been applied to r1357110, just an FYI for future, this is a git diff. You need to provide patches as SVN diffs as Apache hasn't adopted git yet, to our constant dismay. Thanks for the work!
Robert, could you take a look at the commit, if you're happy with it could you close this bug. Thanks
Thanks Mehdi. I have set the status to Closed / fixed. Apologies about the git diff as well. I've been swapping over to using the repository utilizing Geritt and SVN is one of the things I still need to do. I'll make sure any future patches use SVN next time. Thanks!