in method constructUserKey() i found this code near line 82: if (hyphPatNames != null) { String key = constructLlccKey(lang, country); key.replace('_', '-'); <<<<<<<< ======= !!!! userKey = (String) hyphPatNames.get(key); } return userKey; it should be key = key.replace('_', '-'); the code as it is now is without effect.
i found that a specific findbugs-check for this is disabled in file 'findbugs-exclude.xml'. findbugs is right - the code is wrong
(In reply to comment #1) > i found that a specific findbugs-check for this is disabled in file > 'findbugs-exclude.xml'. > > findbugs is right - the code is wrong thanks for tracking this down; that is one of the problems with generating exclusions automatically and not going back to review them; reviewing the findbugs exclusions remains a TBD; could you attach a minimal regression test we can add to test the condition addressed by this fix?
patch applied at http://svn.apache.org/viewvc?rev=1353320&view=rev thanks dieter! please review and close if satisfied... also, if you wish to submit a test case, it would be appreciated...
when you fix the two typos of 'hyphneation' in the same file i'd completly happy. providing a testcase for this might be tricky - the bug is 'deep inside' and i have no idea how to influence hyphenation in fop.
(In reply to comment #4) > when you fix the two typos of 'hyphneation' in the same file i'd completly > happy. done! > providing a testcase for this might be tricky - the bug is 'deep inside' and > i have no idea how to influence hyphenation in fop. well, if you have any thoughts on this in the future, please say so