Bug 52977 - [PATCH] Unit tests for property classes
Summary: [PATCH] Unit tests for property classes
Status: NEW
Alias: None
Product: Fop - Now in Jira
Classification: Unclassified
Component: fo tree (show other bugs)
Version: all
Hardware: All All
: P5 enhancement
Target Milestone: ---
Assignee: fop-dev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-23 11:28 UTC by Vincent Hennebert
Modified: 2012-04-24 14:50 UTC (History)
0 users


Attachments
Unit tests for equals and hashCode on property classes (53.18 KB, patch)
2012-03-23 11:28 UTC, Vincent Hennebert 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vincent Hennebert 2012-03-23 11:28:55 UTC 
Created attachment 28502 [details]
Unit tests for equals and hashCode on property classes

Following the discussion on bug #46962 about testing hashCode and equals for property classes, here is an updated patch with the test cases.

I did some clean-up and started the conversion to JUnit 4.

See discussion in bug #46962 about the pros and cons of this approach at testing equals and hashCode.
Comment 1 Glenn Adams 2012-04-07 01:44:31 UTC 
resetting P2 open bugs to P3 pending further review
Comment 2 Glenn Adams 2012-04-08 09:11:00 UTC 
increase priority due to presence of a patch
Comment 3 Glenn Adams 2012-04-08 21:35:33 UTC 
vincent, what is the status of this patch? do you intend to commit or can it be withdrawn?
Comment 4 Glenn Adams 2012-04-24 05:54:59 UTC 
(In reply to comment #3)
> vincent, what is the status of this patch? do you intend to commit or can it be
> withdrawn?

vincent?
Comment 5 Vincent Hennebert 2012-04-24 14:47:19 UTC 
This patch is not ready to be committed. I don't think it should be withdrawn either, as it may provide a useful base for more systematically testing equals and hashCode.
Comment 6 Glenn Adams 2012-04-24 14:50:29 UTC 
(In reply to comment #5)
> This patch is not ready to be committed. I don't think it should be withdrawn
> either, as it may provide a useful base for more systematically testing equals
> and hashCode.

ok, in that case, i'm changing severity to enhancement and lowering priority to reflect lack of activity/interest at current time (if activity/interest increases, then we can raise priority)