Bug 52614 - MailerModel.sendMail has strange way to calculate debug setting
MailerModel.sendMail has strange way to calculate debug setting
Status: RESOLVED FIXED
Product: JMeter
Classification: Unclassified
Component: Main
2.5.1
PC Windows XP
: P2 normal (vote)
: ---
Assigned To: JMeter issues mailing list
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2012-02-07 01:24 UTC by Sebb
Modified: 2012-02-09 01:13 UTC (History)
0 users



Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sebb 2012-02-07 01:24:02 UTC
MailerModel.sendMail has a strange way to calculate the debug setting:

        boolean debug = Boolean.valueOf(host).booleanValue();

i.e. it will set debug true iff host.equalsIgnoreCase("true").

This code seems to have been there since the beginning of SVN history.

It should either be removed, or be replaced with something more useful.
Comment 1 Sebb 2012-02-07 11:49:18 UTC
A simple solution would be to enable debug for the Test message and not otherwise - thoughts?
Comment 2 Sebb 2012-02-09 01:13:10 UTC
Changed to enable debug for Test message only:

URL: http://svn.apache.org/viewvc?rev=1242199&view=rev
Log:
Bug 52614 - MailerModel.sendMail has strange way to calculate debug setting

Modified:
   jmeter/trunk/src/components/org/apache/jmeter/reporters/MailerModel.java
   jmeter/trunk/xdocs/changes.xml