Bug 52215 - Confusing synchronization in StatVisualizer, SummaryReport ,Summariser and issue in StatGraphVisualizer
Confusing synchronization in StatVisualizer, SummaryReport ,Summariser and is...
Status: RESOLVED FIXED
Product: JMeter
Classification: Unclassified
Component: Main
Nightly (Please specify date)
All All
: P2 minor (vote)
: ---
Assigned To: JMeter issues mailing list
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2011-11-20 10:01 UTC by Philippe Mouawad
Modified: 2011-11-20 11:39 UTC (History)
1 user (show)



Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Mouawad 2011-11-20 10:01:49 UTC
StatVisualizer, SummaryReport ,Summariser do a synchronization on a ConcurrentHashMap.
After reading this is OK but is confusing as ConcurrentHashMap is synchronized, also see:
http://findbugs.sourceforge.net/bugDescriptions.html#JLM_JSR166_UTILCONCURRENT_MONITORENTER


And there is an issue in StatGraphVisualizer where clearData is not protected while a clear can occur during Samples adding.
Comment 1 Philippe Mouawad 2011-11-20 10:04:57 UTC
Date: Sun Nov 20 10:04:02 2011
New Revision: 1204144

URL: http://svn.apache.org/viewvc?rev=1204144&view=rev
Log:
Bug 52215 - Confusing synchronization in StatVisualizer, SummaryReport ,Summariser and issue in StatGraphVisualizer

Modified:
   jmeter/trunk/src/components/org/apache/jmeter/visualizers/StatGraphVisualizer.java
   jmeter/trunk/src/components/org/apache/jmeter/visualizers/StatVisualizer.java
   jmeter/trunk/src/components/org/apache/jmeter/visualizers/SummaryReport.java
   jmeter/trunk/src/core/org/apache/jmeter/reporters/Summariser.java
   jmeter/trunk/xdocs/changes.xml
Comment 2 Philippe Mouawad 2011-11-20 11:39:42 UTC
Date: Sun Nov 20 11:33:19 2011
New Revision: 1204147

URL: http://svn.apache.org/viewvc?rev=1204147&view=rev
Log:
Bug 52215 - Confusing synchronization in StatVisualizer, SummaryReport ,Summariser and issue in StatGraphVisualizer

Lock must be static

Modified:
   jmeter/trunk/src/core/org/apache/jmeter/reporters/Summariser.java