Bug 52136 - [PATCH] Build.xml simplification and JUnit regex
Summary: [PATCH] Build.xml simplification and JUnit regex
Status: CLOSED FIXED
Alias: None
Product: Fop - Now in Jira
Classification: Unclassified
Component: general (show other bugs)
Version: 1.0
Hardware: PC Linux
: P2 normal
Target Milestone: ---
Assignee: fop-dev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-04 14:21 UTC by Mehdi Houshmand
Modified: 2012-03-28 08:46 UTC (History)
0 users



Attachments
Junit-regex patch (323.92 KB, patch)
2011-11-04 14:21 UTC, Mehdi Houshmand
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mehdi Houshmand 2011-11-04 14:21:20 UTC
Created attachment 27895 [details]
Junit-regex patch

This patch changes the build.xml file to reduce some of the code-duplication. It also introduces a regex for finding the Junit test files, the reason I've done this is because some of the tests were being ignored because they didn't appear in a TestSuite. I also think the output produced by junit on the command line more readable.

However, in order to use a regex (**/*TestCase.java), this means that any class in the test file that isn't intended to run (helper files or abstract classes) cannot be called *TestCase.java. I think that's a fairly well established tradition.
Comment 1 Vincent Hennebert 2011-11-07 18:19:57 UTC
Patch applied in rev. 1198853:
http://svn.apache.org/viewvc?revision=1198853&view=revision

I inferred from the patch the files that were renamed, in order to preserve Subversion history. In the future it would be helpful if you could list the files that you renamed and to what.

I removed the junit-full target which no longer has a utility.

Thanks!
Vincent