Bug 52099 - Allow to set the transaction isolation in the JDBC Connection Configuration
Allow to set the transaction isolation in the JDBC Connection Configuration
Status: RESOLVED FIXED
Product: JMeter
Classification: Unclassified
Component: Main
Nightly (Please specify date)
All All
: P2 enhancement (vote)
: ---
Assigned To: JMeter issues mailing list
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2011-10-27 13:42 UTC by Roman Bargezi
Modified: 2011-10-28 11:38 UTC (History)
1 user (show)



Attachments
Patch to nightly build revision 1182604 for porposed enhancement (6.64 KB, patch)
2011-10-27 13:44 UTC, Roman Bargezi
Details | Diff
Proposed fix for Revision 1190010 of DataSourceElementBeanInfo.java (1.64 KB, patch)
2011-10-28 05:42 UTC, Roman Bargezi
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Roman Bargezi 2011-10-27 13:42:39 UTC
For some of our testing we need to be able to set the transaction isolation level of the JDBC connection. This request thus asks to enhance the JDBC Connection Configuration bean to allow for setting the Transaction Isolation Level.
Comment 1 Roman Bargezi 2011-10-27 13:44:19 UTC
Created attachment 27855 [details]
Patch to nightly build revision 1182604 for porposed enhancement
Comment 2 Philippe Mouawad 2011-10-27 20:40:06 UTC
Applied part of patch and changed the following:
- Restricted combo box to the only accepted values + DEFAULT(don't set transactionLevel)
- Removed constants from Resource file
- Used a HashMap instead of 2 tables


Date: Thu Oct 27 20:40:43 2011
New Revision: 1190010

URL: http://svn.apache.org/viewvc?rev=1190010&view=rev
Log:
Bug 52099 - Allow to set the transaction isolation in the JDBC Connection Configuration

Modified:
   jakarta/jmeter/trunk/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/config/DataSourceElement.java
   jakarta/jmeter/trunk/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/config/DataSourceElementBeanInfo.java
   jakarta/jmeter/trunk/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/config/DataSourceElementResources.properties
   jakarta/jmeter/trunk/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/config/DataSourceElementResources_fr.properties
   jakarta/jmeter/trunk/xdocs/changes.xml
Comment 3 Roman Bargezi 2011-10-27 22:03:46 UTC
Please do not restrict the list to "valid" entries! Some drivers support transaction isolation levels that are not part of predefined JDBC isolation modes. We for instance require to run our transactions in snapshot isolation mode which is specific to MS SQL Server (code 4096). Thus you should remove the NOT_OTHER setting or set it to true.
Comment 4 Roman Bargezi 2011-10-27 22:06:18 UTC
Of course this also requires you to change the implementation of getTransactionIsolationMode to parse the potential number enterd by the user.
Comment 5 Roman Bargezi 2011-10-28 05:42:38 UTC
Created attachment 27858 [details]
Proposed fix for Revision 1190010 of DataSourceElementBeanInfo.java
Comment 6 Philippe Mouawad 2011-10-28 11:38:51 UTC
Date: Fri Oct 28 11:40:04 2011
New Revision: 1190256

URL: http://svn.apache.org/viewvc?rev=1190256&view=rev
Log:
Bug 52099 - Allow to set the transaction isolation in the JDBC Connection Configuration

Modified:
   jakarta/jmeter/trunk/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/config/DataSourceElementBeanInfo.java