Bug 52003 - View Results Tree "Scroll automatically" does not scroll properly in case nodes are expanded
View Results Tree "Scroll automatically" does not scroll properly in case nod...
Status: RESOLVED FIXED
Product: JMeter
Classification: Unclassified
Component: Main
2.5.1
All All
: P4 minor (vote)
: ---
Assigned To: JMeter issues mailing list
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2011-10-10 15:21 UTC by Roman Bargezi
Modified: 2011-10-10 20:14 UTC (History)
1 user (show)



Attachments
Proposed patch for Revision 1171996 of ViewResultsFullVisualizer.java (8.77 KB, application/octet-stream)
2011-10-10 15:23 UTC, Roman Bargezi
Details
Proposed patch for Revision 1171996 of ViewResultsFullVisualizer.java (600 bytes, patch)
2011-10-10 15:47 UTC, Roman Bargezi
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Roman Bargezi 2011-10-10 15:21:14 UTC
In the View Results Tree visualizer, the automatic scrolling does not take into account the fact that nodes may have been expanded. It assumes only the children of the root are visible and thus does not properly scroll to the last node that was added.

Testcase:
- Create a test plan with a transaction controller and some samplers
- Add the listener "View Results Tree"
- Set the "Scroll automatically" check-box in the listener
- Run as many test as are necessary to cause the automatic scrolling
- While the tree is populated expand nodes to reveal the sampler results of the transaction nodes
Comment 1 Roman Bargezi 2011-10-10 15:23:14 UTC
Created attachment 27752 [details]
Proposed patch for Revision 1171996 of ViewResultsFullVisualizer.java
Comment 2 Sebb 2011-10-10 15:30:26 UTC
Thanks for the patch. Rather difficult to review, because there are lots of irrelevant changes (e.g. spacing).

Please could you provide a replacement patch that includes only the changes necessary to implement the fix?

Thanks!
Comment 3 Roman Bargezi 2011-10-10 15:47:34 UTC
Created attachment 27753 [details]
Proposed patch for Revision 1171996 of ViewResultsFullVisualizer.java
Comment 4 Roman Bargezi 2011-10-10 15:52:09 UTC
Sebb,

PFA the revised patch
Comment 5 Philippe Mouawad 2011-10-10 20:14:57 UTC
Thanks for the patch.



Date: Mon Oct 10 20:13:50 2011
New Revision: 1181199

URL: http://svn.apache.org/viewvc?rev=1181199&view=rev
Log:
Bug 52003 - View Results Tree "Scroll automatically" does not scroll properly in case nodes are expanded

Modified:
   jakarta/jmeter/trunk/src/components/org/apache/jmeter/visualizers/ViewResultsFullVisualizer.java
   jakarta/jmeter/trunk/xdocs/changes.xml