Bug 51886 - SampleSender configuration resolved partly on client and partly on server
SampleSender configuration resolved partly on client and partly on server
Status: RESOLVED FIXED
Product: JMeter
Classification: Unclassified
Component: Main
2.5
PC Windows XP
: P2 normal (vote)
: ---
Assigned To: JMeter issues mailing list
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2011-09-23 19:20 UTC by Sebb
Modified: 2011-11-13 15:16 UTC (History)
1 user (show)



Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sebb 2011-09-23 19:20:29 UTC
The SampleSender implementations are currently created on the client and sent to the server by RMI.

Such classes are instantiated both on the client and on the server.

The mode property is only used by the client which uses it to determine which SampleSender implementation to use.

However most of the SampleSender implementations use static fields for holding property values, so these will be picked up from the server properties.

Consider whether to switch to client-only configuration; this can easily be done by switching to instance fields (which will be sent to the server).

However, this would preclude using different settings for different servers.
Not sure if there is a use-case for that.
Comment 1 Philippe Mouawad 2011-11-13 14:28:31 UTC
(In reply to comment #0)
> The SampleSender implementations are currently created on the client and sent
> to the server by RMI.
> 
> Such classes are instantiated both on the client and on the server.
> 
> The mode property is only used by the client which uses it to determine which
> SampleSender implementation to use.
> 
> However most of the SampleSender implementations use static fields for holding
> property values, so these will be picked up from the server properties.
> 
> Consider whether to switch to client-only configuration; this can easily be
> done by switching to instance fields (which will be sent to the server).
> 
> However, this would preclude using different settings for different servers.
> Not sure if there is a use-case for that.

Maybe a use-case would be remote engine with different machine configurations (some powerful, others less).
But I think from a user point of view that using one configuration on client side is really better than how it's done actually (replicate client to server by copying config file)
Comment 2 Philippe Mouawad 2011-11-13 15:13:42 UTC
Date: Sun Nov 13 15:12:43 2011
New Revision: 1201437

URL: http://svn.apache.org/viewvc?rev=1201437&view=rev
Log:
Bug 51886 - SampleSender configuration resolved partly on client and partly on server

Added:
   jmeter/trunk/src/core/org/apache/jmeter/samplers/AbstractSampleSender.java   (with props)
Modified:
   jmeter/trunk/bin/jmeter.properties
   jmeter/trunk/src/core/org/apache/jmeter/samplers/AsynchSampleSender.java
   jmeter/trunk/src/core/org/apache/jmeter/samplers/BatchSampleSender.java
   jmeter/trunk/src/core/org/apache/jmeter/samplers/DataStrippingSampleSender.java
   jmeter/trunk/src/core/org/apache/jmeter/samplers/HoldSampleSender.java
   jmeter/trunk/src/core/org/apache/jmeter/samplers/StandardSampleSender.java
   jmeter/trunk/src/core/org/apache/jmeter/samplers/StatisticalSampleSender.java
   jmeter/trunk/xdocs/changes.xml
Comment 3 Philippe Mouawad 2011-11-13 15:16:22 UTC
Added a new jmeter properties called sample_sender_client_configured (defaults to true) that decides how Sample Sender configuration is resolved.
Added an abstract class for SampleSender implementations that holds its value.
Changed implementations to use it.



Date: Sun Nov 13 15:14:49 2011
New Revision: 1201438

URL: http://svn.apache.org/viewvc?rev=1201438&view=rev
Log:
Bug 51886 - SampleSender configuration resolved partly on client and partly on server
Fixed default value