Bug 51855 - Parent samples may have slightly inaccurate elapsed times
Parent samples may have slightly inaccurate elapsed times
Status: RESOLVED FIXED
Product: JMeter
Classification: Unclassified
Component: Main
2.5
All All
: P2 normal (vote)
: ---
Assigned To: JMeter issues mailing list
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2011-09-20 23:50 UTC by Sebb
Modified: 2011-09-21 01:03 UTC (History)
0 users



Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sebb 2011-09-20 23:50:43 UTC
JMeter by default uses System.nanoTime() for timing samples, as this gives greater accuracy than System.currentTimeMillis(). The latter often has a granularity of 10-20 milliseconds.

After it was introduced, it was discovered that nanoTime can drift quite substantially from wall time over the course of a test run.

For this reason, the SampleResult class now only uses nanoTime to enhance the accuracy of currentTimeMillis. It does this by calculating the offset between nanoTime and TimeMillis, effectively resetting the nanoTime with each sample.

This ensures that individual sample times are accurate, without allowing the start and end times to drift from wall time.

However, the nanoTime offset is affected by the TimeMillis granularity; consecutive samples may vary by 10-20 ms. This has the consequence that the current calculation of the parent sample end time may result in the parent elapsed time being shorter than the sum of its constituent elapsed times, or being noticeably greater. The difference can be 10-20 ms either way.

It's more important that elapsed times are accurate, rather than having exact start and end times (these are subject to the TimeMillis granularity anyway).

One fix is to adjust the parent sample end time by the difference in the nanoTime offsets, thus allowing for the drift.

An alternative fix would be to ensure that all the samples in the parent group used the same nanoTime offset; however the offset is currently final. Perhaps consider this for a later release.
Comment 1 Sebb 2011-09-21 01:03:52 UTC
URL: http://svn.apache.org/viewvc?rev=1173443&view=rev
Log:
Bug 51855 - Parent samples may have slightly inaccurate elapsed times

Modified:
   jakarta/jmeter/trunk/src/core/org/apache/jmeter/samplers/SampleResult.java
   jakarta/jmeter/trunk/test/src/org/apache/jmeter/samplers/TestSampleResult.java
   jakarta/jmeter/trunk/xdocs/changes.xml