Bug 51750 - Retrieve all embedded resources doesn't follow IFRAME
Retrieve all embedded resources doesn't follow IFRAME
Status: RESOLVED FIXED
Product: JMeter
Classification: Unclassified
Component: HTTP
2.5
PC All
: P2 normal (vote)
: ---
Assigned To: JMeter issues mailing list
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2011-09-01 11:13 UTC by shmulikk
Modified: 2011-09-01 12:30 UTC (History)
0 users



Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description shmulikk 2011-09-01 11:13:16 UTC
Retrieve all embedded resources follows FRAMESETS but doesn't follow IFRAME.
Example link:

http://www.w3schools.com/html/tryit.asp?filename=tryhtml_iframe_frameborder




Bug fix:
Add the following:

1. To org.apache.jmeter.protocol.http.parser.HTMLParser:

    protected static final String TAG_IFRAME        = "iframe";// $NON-NLS-1$
(line 52)

2. To org.apache.jmeter.protocol.http.parser.HtmlParserHTMLParser:

            } else if (tag instanceof FrameTag
            	||	tagname.equalsIgnoreCase(TAG_IFRAME)){
                binUrlStr = tag.getAttribute(ATT_SRC);
(line 164)
Comment 1 Sebb 2011-09-01 12:30:39 UTC
Thanks for the report and patch.

Seems like HtmlParser does not actually have a class for IFrame.

URL: http://svn.apache.org/viewvc?rev=1164043&view=rev
Log:
Bug 51750 - Retrieve all embedded resources doesn't follow IFRAME

Modified:
   jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/parser/HTMLParser.java
   jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/parser/HtmlParserHTMLParser.java
   jakarta/jmeter/trunk/xdocs/changes.xml