I have 2Mb FO document. FO converts it to PDF in 65-70 sec. Using "poor man's profiler" i optimized some logs calls in BreakingAlgorithm class. Now FO converts document in 54-55 seconds. Document can be provided, if needed.
Created attachment 27405 [details] Patch
Hi Sergey, Thanks for the patch. It looks good in principal. Can you also attach some form of test case? If your own XSL-FO is private then please create an artificial example. Obviously I can create my own test case, but it is good practise to submit a test case with any code change. Thanks, Chris
Chris, It's not a bugfix neither new feature, but a performance patch. So there is no exception neither unworking code that magically became working after applying the patch. What kind of test case you want me to create? I still can provide example document, but the only different thing is execution time. Best regards, Sergey
Hi Sergey, I understand it is not a bug and the change doesn't fix an error. I simply meant that it is good practice to supply a test file for every code change. Regardless of the affect the change has. If I make up a test file I may get very different results from you, and if I perceive no performance improvement then I would be reluctant to commit the change. If however, we use the same test file, then our results should be aligned. Do you see what I mean? Of course, it would be prudent for any developer to try out multiple test files, not just 1, but I still think it would be useful for you to provide a test XSL-FO. Thanks, Chris
(In reply to comment #3) > Chris, > > It's not a bugfix neither new feature, but a performance patch. So there is no > exception neither unworking code that magically became working after applying > the patch. What kind of test case you want me to create? > > I still can provide example document, but the only different thing is execution > time. > > Best regards, > Sergey Sergey, do you expect to provide a test FO file for verifying the impact of your performance patch? if not, then I will move this bug to resolved+wontfix, thanks Glenn
(In reply to comment #5) > Sergey, do you expect to provide a test FO file for verifying the impact of > your performance patch? if not, then I will move this bug to resolved+wontfix, > thanks Glenn Glenn, I'm can't provide test file anymore. Sergey
batch transition resolved+wontfix to closed+wontfix
batch transition resolved+wontfix to closed+wontfix; if you believe this remains a bug and can demonstrate it with appropriate input FO file and output PDF file (as applicable), then you may reopen