Bug 51598 - NSIS - Running Uninstall.exe without arguments
Summary: NSIS - Running Uninstall.exe without arguments
Status: RESOLVED FIXED
Alias: None
Product: Tomcat 7
Classification: Unclassified
Component: Packaging (show other bugs)
Version: 7.0.19
Hardware: PC Windows XP
: P2 normal (vote)
Target Milestone: ---
Assignee: Tomcat Developers Mailing List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-02 00:31 UTC by Konstantin Kolinko
Modified: 2011-08-02 09:22 UTC (History)
0 users


Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Konstantin Kolinko 2011-08-02 00:31:55 UTC 
Reviewing r1152863

CreateShortCut "$SMPROGRAMS\Apache Tomcat @VERSION_MAJOR_MINOR@ $TomcatServiceName\Uninstall Tomcat @VERSION_MAJOR_MINOR@.lnk" \
                 "$INSTDIR\Uninstall.exe" '-ServiceName="$TomcatServiceName"'

The trick of passing argument to Uninstall.exe is a bit flawed:  a user can double click Uninstall.exe in Tomcat installation directory and uninstallation will be launched without this additional argument.

I wonder whether we can derive this name from somewhere (from the name of exe files in bin, or from Registry?) and confirm it,  like uninstaller displays/confirms the name of directory it uninstalls from.

A more simple fix could be to just display a warning and abort deinstallation.
Comment 1 Mark Thomas 2011-08-02 09:22:37 UTC 
Fixed in 7.0.x and will be in 7.0.20 onwards.