Bug 50763 - [PATCH] Size basic-link areas according to descendant areas
Summary: [PATCH] Size basic-link areas according to descendant areas
Status: RESOLVED FIXED
Alias: None
Product: Fop - Now in Jira
Classification: Unclassified
Component: page-master/layout (show other bugs)
Version: all
Hardware: All All
: P2 normal
Target Milestone: ---
Assignee: fop-dev
URL:
Keywords:
: 42501 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-02-11 10:57 UTC by Vincent Hennebert
Modified: 2012-04-05 05:24 UTC (History)
1 user (show)



Attachments
Patch implementing the change (27.55 KB, patch)
2011-02-11 10:57 UTC, Vincent Hennebert
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vincent Hennebert 2011-02-11 10:57:00 UTC
Created attachment 26641 [details]
Patch implementing the change

The descendants of an inline-area are not taken into account when computing the height of the inline-area.

The main real-life scenario is the following: when an image is surrounded by a basic-link element, only a small part of it becomes active ("clickable"), not the whole image.

See full discussion there:
http://markmail.org/thread/d2a5p4dufipdgfp2

Bug report at W3C: http://www.w3.org/Bugs/Public/show_bug.cgi?id=11672

The attached patch breaks the XSL-FO 1.1 Recommendation and sizes basic-link areas according to their descendant areas. More precisely, the block-progression-dimension of the content-rectangles of basic-link areas is computed so as to encompass all the allocation-rectangles of the descendant areas.
Comment 1 Vincent Hennebert 2011-02-11 11:00:05 UTC
*** Bug 42501 has been marked as a duplicate of this bug. ***
Comment 2 Vincent Hennebert 2011-03-09 11:45:33 UTC
Bug has been raised at W3C:
http://www.w3.org/Bugs/Public/show_bug.cgi?id=11672
Comment 3 Chris Bowditch 2012-01-10 16:39:54 UTC
Hi Vincent,

Are you going to commit this patch or are you waiting for a response from the W3C Subgroup?

Thanks,

Chris
Comment 4 Vincent Hennebert 2012-01-11 19:43:07 UTC
Hi Chris,

The patch was committed in rev. 1085058 following a vote on fop-dev@:
http://markmail.org/thread/oxxsx5ljvoxdqvhu

This bug has been left open as a reminder that adjustments might be required once the XSL-FO Working Group has provided clarification.

Vincent
Comment 5 Glenn Adams 2012-04-05 05:24:11 UTC
patch already applied; if future input from XSL-FO group, then can reopen or open new bug