Created attachment 26403 [details] testFragment Patch of MenuFactory, TestPlan and IncludeController to support this enhancement The Include and Module controller logic currently has some bad user flows. Here is the main one I see: User Flow: Update Include File 1. Open Existing Include File -- Contained Element is automatically added to WorkBench 2. Edit File 3. Click on desired Node 4. File->Save Selection As 5. Rename file if needed(it takes the name of the Node() 6. Overwrite Existing? -> Yes This overly complicated flow is introduced because Include-type JMX files are second-rate citizens. They are not part of a Test Plan so they cannot be automatically saved with Ctrl+S. Also, since they cannot contain any save-able Thread Groups, they have to be debugged with another Test Plan that imports it. This is another bad user-flow. Enhancement: Introduce a sub-TestPlan Test Element named Test Fragment that can be used for holding non-executing trees. This element behaves like the Thread Group except that it doesn't execute during a Run->Start. Since it exists underneath the Test Plan element, it can be saved in the more natural flow preventing users from accidentally over-writing their include file with a blank Test Plan. The IncludeController would be enhanced to support importing these Test Fragments while maintaining support for the non-Test Plan JMX files that already exist. A side-affect of this change is that a user could also create a Thread Group for the Include File that can Regress the Test Fragment logic by simply using the ModuleController to run the Test Fragment Tree.
Created attachment 26404 [details] TestFragmentController.java
Created attachment 26405 [details] TestFragmentControllerGUI.java
Created attachment 26406 [details] Screenshot showing how this would exist in the Test Plan Tree
I've had a look at the patch. It seems to work well, and does not appear to affect existing test plans. However, there are some odd bits of code that don't appear to do anything in the TestFragmentControllerGui class: if (element instanceof TestFragmentController) { TestFragmentController testFragmentController = (TestFragmentController) element; } and if (controller instanceof TestFragmentController) { } Is there some code missing here? Or should these code snippets be removed?
Forgot to mention - it would be useful to have a documentation patch for component_reference.xml if at all possible.
The instanceof portions were left-over from the re-use of an existing component. No missing code... they can just be removed. I will update the component_reference.xml and attach shortly.
Created attachment 26412 [details] user_manual patches for test_plan and component_reference
Document patch attached. New Section added in the test_plan.xml to give an overview of the Test Fragment Element and the Include Controller section updated to reflect the new flow.
Thanks very much. Patches applied with a few minor tweaks: URL: http://svn.apache.org/viewvc?rev=1049771&view=rev Log: Bug 50475 - Introduction of a Test Fragment Test Element for a better Include flow Added: jakarta/jmeter/trunk/docs/images/screenshots/test_fragment.png (with props) jakarta/jmeter/trunk/src/components/org/apache/jmeter/control/TestFragmentController.java (with props) jakarta/jmeter/trunk/src/components/org/apache/jmeter/control/gui/TestFragmentControllerGui.java (with props) jakarta/jmeter/trunk/xdocs/images/screenshots/test_fragment.png (with props) Modified: jakarta/jmeter/trunk/bin/saveservice.properties jakarta/jmeter/trunk/src/components/org/apache/jmeter/control/IncludeController.java jakarta/jmeter/trunk/src/core/org/apache/jmeter/control/gui/TestPlanGui.java jakarta/jmeter/trunk/src/core/org/apache/jmeter/gui/util/MenuFactory.java jakarta/jmeter/trunk/src/core/org/apache/jmeter/resources/messages.properties jakarta/jmeter/trunk/xdocs/changes.xml jakarta/jmeter/trunk/xdocs/usermanual/component_reference.xml jakarta/jmeter/trunk/xdocs/usermanual/test_plan.xml Code will be in nightly builds from r1049771
This issue has been migrated to GitHub: https://github.com/apache/jmeter/issues/2441