Bug 50240 - [PATCH] Upgrade to Java 1.5 - Converted EncodingMode to an Enum
Summary: [PATCH] Upgrade to Java 1.5 - Converted EncodingMode to an Enum
Status: CLOSED FIXED
Alias: None
Product: Fop - Now in Jira
Classification: Unclassified
Component: fonts (show other bugs)
Version: all
Hardware: PC Linux
: P2 minor
Target Milestone: ---
Assignee: fop-dev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-09 11:35 UTC by Mehdi Houshmand
Modified: 2012-03-28 08:39 UTC (History)
0 users


Attachments
EncodingMode changed from class -> enum (3.92 KB, patch)
2010-11-09 11:35 UTC, Mehdi Houshmand 		Details | Diff
EncodingMode changed from class -> enum + JUnit test (4.77 KB, patch)
2010-11-09 11:39 UTC, Mehdi Houshmand 		Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mehdi Houshmand 2010-11-09 11:35:11 UTC 
Created attachment 26272 [details]
EncodingMode changed from class -> enum

In light of the recent vote to convert to Java5, I have changed o.a.f.fonts.EncodingMode.java to an enumerated type. I've also added a JUnit test for this enum. I have tested this enum with various different fonts and diffed them to ensure there are no differences.
Comment 1 Mehdi Houshmand 2010-11-09 11:39:46 UTC 
Created attachment 26273 [details]
EncodingMode changed from class -> enum + JUnit test

Sorry I failed to add the JUnit test
Comment 2 Simon Pepping 2010-11-11 04:49:43 UTC 
Applied with changes. Thanks for your contribution. Simon