Bug 50230 - Recursive dependency between the tomcat-catalina-ha and tomcat-catalina
Summary: Recursive dependency between the tomcat-catalina-ha and tomcat-catalina
Status: RESOLVED FIXED
Alias: None
Product: Tomcat 7
Classification: Unclassified
Component: Manager (show other bugs)
Version: 7.0.4
Hardware: PC Windows XP
: P2 normal (vote)
Target Milestone: ---
Assignee: Tomcat Developers Mailing List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-07 21:04 UTC by Ivan
Modified: 2010-11-11 17:11 UTC (History)
0 users



Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ivan 2010-11-07 21:04:22 UTC
From the pom file of tomcat-catalina-ha, it depends on the tomcat-catalina. But one class HTMLManagerServlet in the tomcat-catalina has a reference to a class BackupManager in the tomcat-catalina-ha.  Is there a way to remove the recursive dependency between those two components ?
    By the way, there mightbe a NullPointerException issue while using the BackupManager in the HTMLManagerServlet.
    ---> line.523
     Manager manager = ctxt.getManager();
                if (manager instanceof BackupManager && showProxySessions) {
                    args[5] = new Integer(
                            ((BackupManager)manager).getActiveSessionsFull());
                } else if (ctxt.getManager() != null){
                    args[5] = new Integer(manager.getActiveSessions());
                } else {
                    args[5] = new Integer(0);
                }
    <---

Please also check the thread from
http://www.mail-archive.com/users@tomcat.apache.org/msg83188.html
Comment 1 Mark Thomas 2010-11-09 10:34:33 UTC
As was pointed out on the referenced thread there is no NPE risk here.
Comment 2 Mark Thomas 2010-11-11 17:11:28 UTC
Fixed in trunk and will be in 7.0.5 onwards.