Bug 48747 - TCP Sampler swallows exception samples
Summary: TCP Sampler swallows exception samples
Status: RESOLVED FIXED
Alias: None
Product: JMeter - Now in Github
Classification: Unclassified
Component: Main (show other bugs)
Version: 2.3.4
Hardware: PC Windows XP
: P2 normal (vote)
Target Milestone: ---
Assignee: JMeter issues mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-16 08:12 UTC by Andrey Pohilko
Modified: 2010-02-16 15:22 UTC (History)
0 users


Attachments
Here's proposed changes to source code to fix the issue (776 bytes, application/octet-stream)
2010-02-16 08:17 UTC, Andrey Pohilko 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Pohilko 2010-02-16 08:12:58 UTC 
When exception occurs during sample in TCP sampler, such samples won't appear in results and will be hidden. This may affect test consistency.

Eg if we use BinaryTCPClientImpl class and passing uneven hex data (000), an exception will be thrown by BinaryTCPClientImpl but not caught by TCPSampler.

I suggest to add handling such exceptions by TCPSampler, keep logging and generate failed sample.
Comment 1 Andrey Pohilko 2010-02-16 08:17:25 UTC 
Created attachment 24994 [details]
Here's proposed changes to source code to fix the issue

By the way I want to check if diff file format is correct and I may send larger patches in this format.
Comment 2 Sebb 2010-02-16 15:22:23 UTC 
Thanks, that patch applied perfectly:

URL: http://svn.apache.org/viewvc?rev=910559&view=rev
Log:
Bug 48747 - TCP Sampler swallows exceptions

Modified:
   jakarta/jmeter/trunk/src/protocol/tcp/org/apache/jmeter/protocol/tcp/sampler/TCPSampler.java
   jakarta/jmeter/trunk/xdocs/changes.xml
Comment 3 The ASF infrastructure team 2022-09-24 20:37:44 UTC 
This issue has been migrated to GitHub: https://github.com/apache/jmeter/issues/2342