Bug 47940 - [Patch] Module controller incorrectly create the replacement Sub Tree
[Patch] Module controller incorrectly create the replacement Sub Tree
Status: RESOLVED FIXED
Product: JMeter
Classification: Unclassified
Component: Main
2.3.4
All All
: P2 major (vote)
: ---
Assigned To: JMeter issues mailing list
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2009-10-05 12:13 UTC by benoit.wiart
Modified: 2009-11-14 15:25 UTC (History)
0 users



Attachments
Patch (681 bytes, patch)
2009-10-05 12:25 UTC, benoit.wiart
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description benoit.wiart 2009-10-05 12:13:19 UTC
The module controller incorrectly re-create the linked controller during the JMeter#convertSubTree step leading to erroneous scenario.

For example if we have a scenario like
TG1
	Transaction Controller
		Sampler 1
		Sampler 2
		Sampler 3

TG 2
	Module Controller (TG 1 > Transaction Controller)

Note that the Transaction Controller could be repladec by any controller (IfController, etc...)


After the JMeter#convertSubTree step, the resulting tree for TG2 will be :
TG 2 {
	Module Controller {
		Transaction Controller {}
		Sampler 1{}
		Sampler 2{}
		Sampler 3{}
	}
}
Here the samplers and the transaction controller are sibling nodes

The correct tree should be :
TG 2 {
	Module Controller {
		Transaction Controller {
			Sampler 1{}
			Sampler 2{}
			Sampler 3{}
		}
	}
}
Where the samplers are child of the Transaction controller

Patch will follow
Comment 1 benoit.wiart 2009-10-05 12:25:18 UTC
Created attachment 24345 [details]
Patch

The patch provided pass the correct subtree to the ModuleController#createSubTree

Benoit Wiart
Ubik Ingénierie
http://www.ubik-ingenierie.com
Comment 2 Sebb 2009-11-14 15:25:07 UTC
Thanks:

URL: http://svn.apache.org/viewvc?rev=836291&view=rev
Log:
Bug 47940 - Module controller incorrectly creates the replacement Sub Tree