Bug 47859 - added regression to font-shorthand-test.fo that shows bug
Summary: added regression to font-shorthand-test.fo that shows bug
Status: CLOSED DUPLICATE of bug 47709
Alias: None
Product: Fop - Now in Jira
Classification: Unclassified
Component: fo tree (show other bugs)
Version: 0.95
Hardware: PC Windows XP
: P2 normal
Target Milestone: ---
Assignee: fop-dev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-17 06:09 UTC by Jonathan Levinson
Modified: 2012-04-01 13:55 UTC (History)
0 users



Attachments
patch to font short hand test that shows bug in functionality (1.57 KB, patch)
2009-09-17 06:11 UTC, Jonathan Levinson
Details | Diff
Fix problems in font short hand (1.67 KB, patch)
2009-09-17 08:59 UTC, Jonathan Levinson
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Levinson 2009-09-17 06:09:35 UTC
I added a regression to font-shorthand-test.fo that shows a bug in font shorthand capability.

We apparently have trouble handling the case where a quoted font follows an unquoted font in the comma separated list of fonts.

Here is the case that fails:

     <fo:block font="xx-large/1.4 Arial, 'Times New Roman', sans-serif">
        <test:assert property="font-family" expected="[Arial, Times New Roman, sans-serif]"/>
        <test:assert property="font-size" expected="20736mpt"/>
        <test:assert property="font-weight" expected="400" />
        <test:assert property="font-style" expected="NORMAL" />
        <test:assert property="line-height.optimum" expected="29030mpt" />
        <test:assert property="font-variant" expected="NORMAL" />
        Test font shorthand
      </fo:block>

The error message is the following:

file:/C:/perforce/Users/levinson/fop-trunk/test/fotree/testcases/font-shorthand-test.fo Property 'font-family' expected to evaluate to '[Arial, Times New Roman, sans-serif]' but got '[sans-serif, Symbol, ZapfDingbats]' (test:assert in fo:block at line #72, column #94)

I add a patch file.
Comment 1 Jonathan Levinson 2009-09-17 06:11:44 UTC
Created attachment 24282 [details]
patch to font short hand test that shows bug in functionality
Comment 2 Jonathan Levinson 2009-09-17 08:59:18 UTC
Created attachment 24283 [details]
Fix problems in font short hand

I fix two problems in font shorthand with this patch:

1) font-weight precedes unquoted font name
2) font-name list begins with unquoted font name, but has quoted font name in middle
Comment 3 Vincent Hennebert 2009-09-21 04:13:27 UTC

*** This bug has been marked as a duplicate of bug 47709 ***
Comment 4 Glenn Adams 2012-04-01 13:55:46 UTC
batch transition to closed remaining pre-FOP1.0 resolved bugs