Bug 47669 - Fix build with commons-net 2.0
Summary: Fix build with commons-net 2.0
Status: RESOLVED FIXED
Alias: None
Product: Ant
Classification: Unclassified
Component: Optional Tasks (show other bugs)
Version: 1.7.1
Hardware: PC Linux
: P2 enhancement (vote)
Target Milestone: 1.8.0
Assignee: Ant Notifications List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-10 04:33 UTC by Alexander Kurtakov
Modified: 2009-08-13 03:16 UTC (History)
0 users



Attachments
The patch. (797 bytes, application/octet-stream)
2009-08-10 04:33 UTC, Alexander Kurtakov
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Kurtakov 2009-08-10 04:33:57 UTC
Created attachment 24122 [details]
The patch.

The attached patch fixes compilation with commons-net 2.0. 
This patch is entirely backward-compatible because both constants
IMAGE_FILE_TYPE and BINARY_FILE_TYPE have the same value in commons-net 1.4 but
IMAGE_FILE_TYPE is removed in commons-net 2.0.
This change is needed for Linux distributions shipping ant with system
installed jars (e.g. commons-net) and needing updated commons-net for other
software.
Thanks in advance.
Comment 1 Alexander Kurtakov 2009-08-10 04:35:20 UTC
Also it may be a good time to update ant to using commons-net 2.0 by default.
Comment 2 Stefan Bodewig 2009-08-13 03:16:37 UTC
committed in svn revision 803830

Thanks

We won't switch to commons-net 2.0 as our default since this requires Java5 while Ant's trunk still wants to support Java 1.4