Bug 47377 - [Patch] Make ClassFinder more robust and close zipfile resources
Summary: [Patch] Make ClassFinder more robust and close zipfile resources
Status: RESOLVED FIXED
Alias: None
Product: JMeter - Now in Github
Classification: Unclassified
Component: Main (show other bugs)
Version: 2.3.3
Hardware: All All
: P2 normal (vote)
Target Milestone: ---
Assignee: JMeter issues mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-06-16 12:41 UTC by benoit.wiart
Modified: 2009-06-16 15:12 UTC (History)
0 users


Attachments
patch (1.49 KB, patch)
2009-06-16 12:42 UTC, benoit.wiart 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description benoit.wiart 2009-06-16 12:41:34 UTC 
1- ClassFinder#findClassesInOnePath(String, Set) does not close the opened zipfile 
2- if a corrupted jar (= a file with the jar extension which is not a jar) is in the search path, jmeter will start but will be unusable
With this patch, the method log the error but check the other jar files

Benoit Wiart
Ubik Ingénierie
www.ubik-ingenierie.com
Comment 1 benoit.wiart 2009-06-16 12:42:50 UTC 
Created attachment 23819 [details]
patch
Comment 2 Sebb 2009-06-16 15:12:56 UTC 
Thanks for reporting this and the patch, which has been applied to SVN:

URL: http://svn.apache.org/viewvc?rev=785427&view=rev
Log:
Bug 47377 - Make ClassFinder more robust and close zipfile resources
Comment 3 The ASF infrastructure team 2022-09-24 20:37:43 UTC 
This issue has been migrated to GitHub: https://github.com/apache/jmeter/issues/2247