Bug 46144 - QuietWriter.write should ignore all Exceptions
Summary: QuietWriter.write should ignore all Exceptions
Status: RESOLVED FIXED
Alias: None
Product: Log4j - Now in Jira
Classification: Unclassified
Component: Appender (show other bugs)
Version: 1.2
Hardware: PC Mac OS X 10.4
: P2 normal
Target Milestone: ---
Assignee: log4j-dev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-11-04 09:52 UTC by Stepan Koltsov
Modified: 2009-01-08 10:14 UTC (History)
0 users


Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stepan Koltsov 2008-11-04 09:52:42 UTC 
QuietWriter.write should ignore all Exception's, not only IOException.

Actually, it should ignore NullPointerException or just check input string for null.

java.util.Writer.write

throws NullPointerException if passed string is null, and if null string accidentally appeared in QuietWriter.write, it should be ignored, rather then NullPointerException thrown.

Currently we have rare NullPointerException in logs somewhere inside log4j, and we cannot repeat this situation:

===
java.lang.NullPointerException
        at java.io.Writer.write(Writer.java:140)
        at org.apache.log4j.helpers.QuietWriter.write(QuietWriter.java:48)
        at org.apache.log4j.WriterAppender.subAppend(WriterAppender.java:309)
        at org.apache.log4j.WriterAppender.append(WriterAppender.java:160)
        at ru.yandex.video.converter.convert.ConfiguredFileAppender.append(ConfiguredFileAppender.java:23)
        at org.apache.log4j.AppenderSkeleton.doAppend(AppenderSkeleton.java:251)
===

log4j is 1.2.15. Proposed solution avoids NullPointerException (though probably causes some information loss).
Comment 1 Curt Arnold 2009-01-08 10:14:39 UTC 
Added check for null argument in rev 732774.