Bug 45734 - [PATCH] regression: "descender" sign inverted in font metrics for PFM (distorted line spacing for fo:inline)
Summary: [PATCH] regression: "descender" sign inverted in font metrics for PFM (distor...
Status: CLOSED FIXED
Alias: None
Product: Fop - Now in Jira
Classification: Unclassified
Component: fonts (show other bugs)
Version: 0.95
Hardware: PC Linux
: P2 normal
Target Milestone: ---
Assignee: fop-dev
URL:
Keywords: PatchAvailable
Depends on:
Blocks:
 
Reported: 2008-09-03 05:50 UTC by J
Modified: 2012-04-01 06:59 UTC (History)
0 users


Attachments
Patch for PFMReader (596 bytes, patch)
2008-09-03 05:50 UTC, J 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description J 2008-09-03 05:50:09 UTC 
Created attachment 22520 [details]
Patch for PFMReader

When we switched to FOP 0.95 and re-ran PFMReader on our .pfm files, the line spacing suddenly became distorted on lines that contained fo:inline tags that used a different font-family.

It turned out that the font metrics produced by FOP 0.95 have an inverted sign for the descender value. When inverting it again (i.e. remove the minus sign in the font metrics xml), all was well again.

It seems that this is due to changes to PFMFile in r56078 for bug#43089. Our fix was to invert the sign in PFMReader on producing the metrics file, since the sign inversion in PFMFile seems to be needed.
Comment 1 Jeremias Maerki 2008-09-10 03:58:23 UTC 
Thanks! Patch applied to FOP Trunk:
http://svn.apache.org/viewvc?rev=693781&view=rev

Please note that with 0.95, the font metrics files are no longer necessary. You can simply forget about the PFMReader and the TTFReader. Please see the following page for details:
http://xmlgraphics.apache.org/fop/0.95/fonts.html#basics
Comment 2 Glenn Adams 2012-04-01 06:59:54 UTC 
batch transition pre-FOP1.0 resolved+fixed bugs to closed+fixed