Bug 45481 - Source contains unused imports
Source contains unused imports
Status: RESOLVED FIXED
Product: Log4j
Classification: Unclassified
Component: Other
1.2
PC Windows XP
: P2 trivial
: ---
Assigned To: log4j-dev
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2008-07-25 02:48 UTC by Thorbjørn Ravn Andersen
Modified: 2009-10-11 13:59 UTC (History)
0 users



Attachments
imports organized and patch created (120.93 KB, patch)
2008-07-25 02:48 UTC, Thorbjørn Ravn Andersen
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thorbjørn Ravn Andersen 2008-07-25 02:48:34 UTC
Created attachment 22315 [details]
imports organized and patch created
Comment 1 Curt Arnold 2008-08-05 10:53:20 UTC
I originally added this comment to the wrong bug (bug 45482) while I was travelling.  Really try to minimize cosmetic changes to the code base to make it easier for a reviewer to see what changed between versions.  I'd be okay with some localized changes for real issues and not just where a refactoring tool wants to sort the imports differently or add a whitespace line or so. 

>The patch touches a lot of files that did not have extra imports.  Quite a few
>files only differed in whitespace or import order.  Would prefer that only
>files with extra imports were touched by patches for this bug.  Unclear which
>files actually did have extra imports.


Comment 2 Curt Arnold 2009-10-11 13:59:39 UTC
Removed unnecessary imports in rev 824147.  Replaced wildcard imports in rev 824150.