Bug 45369 - Footnotes Rendered at Top of Page when Using the Intermediate Format
Summary: Footnotes Rendered at Top of Page when Using the Intermediate Format
Status: CLOSED FIXED
Alias: None
Product: Fop - Now in Jira
Classification: Unclassified
Component: general (show other bugs)
Version: all
Hardware: All All
: P2 normal
Target Milestone: ---
Assignee: fop-dev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-07-09 10:07 UTC by Vincent Hennebert
Modified: 2012-04-01 06:39 UTC (History)
0 users


Attachments
Patch that should solve the issue (4.06 KB, patch)
2008-07-09 10:07 UTC, Vincent Hennebert 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vincent Hennebert 2008-07-09 10:07:54 UTC 
Created attachment 22239 [details]
Patch that should solve the issue

Take for example the footnote_basic.xml file in the layoutengine testcases. Render it into xml (intermediate format). Then create a PDF version (or whatever) out of the xml file. The footnote will be found at the top of the page.

The problem is that the XML renderer doesn't store the offset of the footnote area from the top of the region-body. And the AreaTreeParser doesn't parse any such attribute in return.

The attached patch should fix the issue, but I'd prefer a Renderer/Area Tree specialist to review it in order to check that it fits well into the big picture, before committing it.


Thanks,
Vincent
Comment 1 Jeremias Maerki 2008-07-10 03:30:29 UTC 
Looks perfect, Vincent. +1 to committing the patch as is. Thanks for noticing/fixing that.
Comment 2 Vincent Hennebert 2008-07-10 07:32:35 UTC 
Fix committed in revision 675590.
Thanks for the review,
Vincent
Comment 3 Glenn Adams 2012-04-01 06:39:58 UTC 
batch transition pre-FOP1.0 resolved+fixed bugs to closed+fixed