Bug 45029 - Additional unit tests for Filters in extras companion
Summary: Additional unit tests for Filters in extras companion
Status: RESOLVED LATER
Alias: None
Product: Log4j - Now in Jira
Classification: Unclassified
Component: Other (show other bugs)
Version: unspecified
Hardware: PC Mac OS X 10.4
: P2 normal
Target Milestone: ---
Assignee: log4j-dev
URL:
Keywords:
Depends on:
Blocks: 43313
  Show dependency tree
 
Reported: 2008-05-18 13:10 UTC by Curt Arnold
Modified: 2010-02-13 20:09 UTC (History)
0 users


Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Curt Arnold 2008-05-18 13:10:48 UTC 
The filters provided by the extras companion have very little test coverage.  This bug will be used to add additional unit tests.  This is in conjunction with porting the filters to log4cxx (https://issues.apache.org/jira/browse/LOGCXX-276)
Comment 1 Curt Arnold 2008-05-18 13:16:33 UTC 
Initial commit in rev 657626.  More tests are needed for ExpressionFilter and rules.
Comment 2 Thorbjørn Ravn Andersen 2008-08-02 09:47:59 UTC 
Could you provide a list of tests needed?
Comment 3 Curt Arnold 2008-08-05 16:57:48 UTC 
This bug is driven by the tests needed to implement ExpressionFilter for log4cxx.  There isn't a list, there is just code that has no tests.  If someone wants to start writing unit tests for ExpressionFilter, feel free.   Just the standard procedure of writing unit tests for existing code and trying to approach 100% coverage.

If additional tests aren't written before time for a log4j 1.2.16 release, then this bug can be closed as fixed and a new bug opened for the next batch of tests. Commits against a bug should not span releases, so that the bug can be used as part of the change log.