Bug 44551 - SocketHubAppender in the 1.2.16 does not support a scroll back buffer or application property
SocketHubAppender in the 1.2.16 does not support a scroll back buffer or appl...
Status: RESOLVED FIXED
Product: Log4j
Classification: Unclassified
Component: Appender
1.2
PC All
: P2 enhancement
: ---
Assigned To: log4j-dev
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2008-03-06 12:15 UTC by Jason Tholstrup
Modified: 2008-03-06 22:27 UTC (History)
1 user (show)



Attachments
Patch to fix the issues listed in the description (4.08 KB, patch)
2008-03-06 12:15 UTC, Jason Tholstrup
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jason Tholstrup 2008-03-06 12:15:24 UTC
Created attachment 21644 [details]
Patch to fix the issues listed in the description

Part 1)
The 1.3 version of SocketHubAppender uses a cyclic buffer to store the last X log messages that are delivered to the client on connection so that they can have some of the recently logged events. This was never back ported to the 1.2.X branch.

Part 2)
The 1.2.X version of SocketAppender supports an application property which chainsaw can read to specify which application the log is for.  SocketHubAppender should also support this functionality.

The attached patch resolves these issues.

Thanks to Scott Deboy for his guidance.
Comment 1 Paul Smith 2008-03-06 18:49:05 UTC
This patch looks good to me, I can't see any reason not to apply it.

Scott?  any final comments?
Comment 2 Scott Deboy 2008-03-06 20:53:21 UTC
Looks good to me as well.

Thanks for the contribution Jason
Comment 3 Paul Smith 2008-03-06 21:44:00 UTC
Patch applied as of revision 634545.

Thanks muchly.
Comment 4 Jacob Kjome 2008-03-06 21:51:51 UTC
Can we presume that the Apache Contributor Agreement has been signed and is on file at the foundation?

Jake
Comment 5 Paul Smith 2008-03-06 22:08:57 UTC
I thought that if a person attached their contribution to bugzilla that was implied donation to Apache?
Comment 6 Scott Deboy 2008-03-06 22:24:17 UTC
I agree with Paul..I don't think a CLA is required for submitted patches.
Comment 7 Jacob Kjome 2008-03-06 22:27:31 UTC
My misunderstanding.  From http://www.apache.org/licenses/ ...

"The ASF desires that all contributors of ideas, code, or documentation to the
Apache projects complete, sign, and submit (via postal mail, fax or email) an
Individual Contributor License Agreement (CLA) [PDF form]."

Looks like it isn't "required", but "desired" for general contributors. 
However, for committers it is required...

"A signed CLA is required to be on file before an individual is given commit
rights to an ASF project."

Sorry for the noise.

Jake