Bug 42790 - PropertyName equals() fails when using object reference comparison
PropertyName equals() fails when using object reference comparison
Status: NEW
Product: Slide
Classification: Unclassified
Component: Core
Nightly
All All
: P2 regression (vote)
: ---
Assigned To: Slide Developer List
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2007-07-02 01:45 UTC by Martin Kal
Modified: 2007-07-02 01:46 UTC (History)
0 users



Attachments
Reverting to String equals() comparision in PropertyName#equals() (1.11 KB, patch)
2007-07-02 01:46 UTC, Martin Kal
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Kal 2007-07-02 01:45:49 UTC
PropertyName equals() using the optimized == comparision of intern():ed String
references fails to comply with the desired definition of equals, eg when using
JNDIPrincipalStore.

SVN r429274 introduces this regression.

Previous PropertyName equals() method using String.equals() works as intended.

Suggest either reverting r429274, reviewing PropertyName .intern() usage
altogether or applying attached patch.

See also
http://mail-archives.apache.org/mod_mbox/jakarta-slide-dev/200706.mbox/%3c4682B978.5090607@apache.org%3e
Comment 1 Martin Kal 2007-07-02 01:46:56 UTC
Created attachment 20426 [details]
Reverting to String equals() comparision in PropertyName#equals()