Bug 42428 - Workbench not saved with Test Plan
Summary: Workbench not saved with Test Plan
Status: RESOLVED FIXED
Alias: None
Product: JMeter - Now in Github
Classification: Unclassified
Component: Main (show other bugs)
Version: 2.5.1
Hardware: All All
: P4 enhancement with 4 votes (vote)
Target Milestone: ---
Assignee: JMeter issues mailing list
URL:
Keywords: PatchAvailable
Depends on:
Blocks:
 
Reported: 2007-05-15 12:21 UTC by Kristian Balinski
Modified: 2013-04-07 14:58 UTC (History)
2 users (show)



Attachments
saving WorkBench to JMX (8.61 KB, patch)
2013-04-03 13:13 UTC, Dzmitry Kashlach
Details | Diff
updated patch (14.41 KB, patch)
2013-04-05 10:07 UTC, Dzmitry Kashlach
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kristian Balinski 2007-05-15 12:21:57 UTC
Whenever I save my Test Plan the current WorkBench is not saved along with the
Test Plan. I saved using "Ctrl-S" and "File > Save". I can save the WorkBench as
its own ".jmx" file and then merge that into my Test Plan, but when I save my
Test Plan again the merge that I made ceases to exist.

This is rather annoying since I have set up a HTTP Proxy Server that has a long
list of includes and excludes which takes a lot of effort to setup due to the
usability (or lack of) of the includes and excludes UI.

Im not sure whether this is by design or a bug, but seems to be a bug. As I see
it JMeter loads one Test Plan at a time. Hence that workbench should be
associated with one Test Plan since all Test Plans are going to be inherently
different hence what works for one Test Plan in the workbench may not work for
another. If the argument above does not settle well on the palate then the
workbench should be global and saved as part of each users application settings.
Or an HTTP Proxy Server should be able to be under a Test Plan.

NOTE: Using Sun's JRE 1.6.0_01
Comment 1 Sebb 2007-05-15 13:19:01 UTC
Currently, this is by design.

Changing to enhancement.
Comment 2 Philippe Mouawad 2011-10-10 21:09:11 UTC
Is this useful now with Test Fragment ?
Comment 3 Dzmitry Kashlach 2013-04-03 13:13:58 UTC
Created attachment 30142 [details]
saving WorkBench to JMX

  Hi,

  Please, review my patch for this bug. I've added saving WorkBench in test HashTree.
Comment 4 Sebb 2013-04-04 00:11:59 UTC
As it stands, the patch unconditionally saves the Workbench with the Test Plan.
This is a significant change and will adversely affect those who use the Workbench as a scratch pad. The saving of the Workbench should be optional.

Also the patch includes lots of irrelevant changes - for example, the import statements are re-arranged, and some spacing is changed.

Documentation also needs to be updated.
Comment 5 Dzmitry Kashlach 2013-04-05 10:07:19 UTC
Created attachment 30156 [details]
updated patch

 Sebb,

 I've added check-box to WorkBechGui to let user choose whether to save WB or not.
Comment 6 Philippe Mouawad 2013-04-07 14:56:54 UTC
Date: Sun Apr  7 14:55:37 2013
New Revision: 1465406

URL: http://svn.apache.org/r1465406
Log:
Bug 42428 - Workbench not saved with Test Plan
Bugzilla Id: 42428

Modified:
    jmeter/trunk/src/core/org/apache/jmeter/control/gui/WorkBenchGui.java
    jmeter/trunk/src/core/org/apache/jmeter/gui/action/Save.java
    jmeter/trunk/src/core/org/apache/jmeter/gui/tree/JMeterTreeModel.java
    jmeter/trunk/src/core/org/apache/jmeter/resources/messages.properties
    jmeter/trunk/src/core/org/apache/jmeter/resources/messages_fr.properties
    jmeter/trunk/src/core/org/apache/jmeter/testelement/WorkBench.java
    jmeter/trunk/xdocs/changes.xml
Comment 7 Philippe Mouawad 2013-04-07 14:58:43 UTC
Thanks for patch.
Applied with following modifications:
- saveWorkbench was static with side effect of impacting all test plans, made it a property
- Also removed some useless formatting changes
Comment 8 The ASF infrastructure team 2022-09-24 20:37:39 UTC
This issue has been migrated to GitHub: https://github.com/apache/jmeter/issues/1945